Yevgenium / weather-chart-card

Custom weather card with charts
MIT License
275 stars 81 forks source link

HA 2021.6: maxBarThickness is deprecated #57

Closed Mariusthvdb closed 3 years ago

Mariusthvdb commented 3 years ago

from ha 2021.6 on:

Schermafbeelding 2021-05-31 om 11 32 13

according to Discord #beta this has to do with a bump in chart.js

tried to solve it locally by adding

          {
           maxBarThickness: 15,
          },

under datasets, and this makes the warning disappear. (as does taking out the line completely without replacing it......) cant say if this is a correct fix, because nothing's happening at all... please have a look?

inthehoose commented 3 years ago

I added barThickness and maxBarThickness attributes here to my local file to get the precipitation bars to appear again:

          {
            label: this.ll('precip'),
            type: 'bar',
            data: precip,
            yAxisID: 'PrecipAxis',
            maxBarThickness: 15,
            barThickness: 12,
          },
Mariusthvdb commented 3 years ago

can you please post a pic of what it does? I cant see any difference locally.

inthehoose commented 3 years ago

Clear your browser cache so the updated .js file can be downloaded.

Mariusthvdb commented 3 years ago

I know how to update a custom card..... ;-)

its just that I wonder what the change actually does (I see no difference )

so please show a pic of the card with the fix?

this is what I have:

Schermafbeelding 2021-06-12 om 11 15 38
Mariusthvdb commented 3 years ago

will close, as the latest edits and now PR #60 has this fixed.