Yevgenium / weather-chart-card

Custom weather card with charts
MIT License
275 stars 81 forks source link

HACS integration stopped working #64

Closed artemyevav closed 2 years ago

artemyevav commented 3 years ago

Maybe "filename" in the config is wrong https://github.com/Yevgenium/weather-chart-card/blob/0c16ee74a90c8b0902d4a989d883f9d2207331c7/hacs.json#L4

gdreelin commented 3 years ago

Mine also stopped working right but also notice the .js file is named different than the one that downloads from HACS. The one that downloaded is weather-card-chart.js and the one on the github is weather-chart-card.js

gdreelin commented 3 years ago

Ok the fix I found was to add the new .js file and rename it to the one in HA. Reboot and then HACS will allow you to reinstall it which fixed the issue. All good now.

Yevgenium commented 3 years ago

Oops. Can you check if it works now?

gdreelin commented 3 years ago

Oops. Can you check if it works now?

Well actually I jump for joy too early. It failed again so removed it form HACS then tried to add it back into custom repositories but it will not allow you to add your repository. I was able to do it old school by manually added it back in, but I like to have it linked to HACS to do updates. I love this card too so really want it to work.

gdreelin commented 3 years ago

I also tired to clear cache and reboot HA to see if you can link the repository back in but no joy. I put in your url "https://github.com/Yevgenium/weather-chart-card" for Lovelace installment in custom repositories in HACS but it will not add it to the list when it was working before I deleted it to see if I could get it to update to current version. Not sure why it will not add now since it seems to be all correct now.

artemyevav commented 3 years ago

There's no file weather-card-chart.js in the repo, it was deleted in a9f795f2fd02028bdad9b771d383fa38c5f3148c. Maybe that's the reason?

Yevgenium commented 3 years ago

Yes, this was probably the reason. I edited the hacs.json file, hopefully this will fix the problem.

gdreelin commented 3 years ago

I just check but no joy. It still will not let you add it to custom repositories in HACS. Honestly not sure why I put in the URL and Lovelace but you click add and nothing. No errors or anything. Manual install works but better if it was in HACS.

artemyevav commented 3 years ago

https://github.com/artemyevav/weather-chart-card/commit/1883526f493b7de2868c7f108da685766a8cc6e9 <-- it works in my repo as expected. HACS requires the compiled js to exist in the tree. And BTW - your last changes to that file make it failing, I used the js from release 1.0.0

gdreelin commented 3 years ago

@artemyevav yeah it did work with your fork without any issues. Only thing is will it have the updates as they are pushed out?

artemyevav commented 3 years ago

Nope. I believe you have to put .js there manually. Maybe it worth creating smth like bin subdir and keep it there.

gdreelin commented 3 years ago

@artemyevav yeah that is what I thought. I tried again to get this repo to add but no joy for some reason.

artemyevav commented 3 years ago

Reload hass page maybe and clean the cache. It helps sometimes.

gdreelin commented 3 years ago

Yeah I did that a few times but same thing. I am just going to use your repo and manually do it.

artemyevav commented 3 years ago

The only difference of my repo is https://github.com/artemyevav/weather-chart-card/commit/1883526f493b7de2868c7f108da685766a8cc6e9 which means I got weather-chart-card.js from release and put it into the repo.

gdreelin commented 3 years ago

@artemyevav yeah I see that but for some unknown reason it will not load into HACS at all. Got me scratching my head.

yan14 commented 3 years ago

same here :)

artemyevav commented 3 years ago

Hmm. No idea. I've just completely removed it from my HACS and installed it again from my repo - it works.

yan14 commented 3 years ago

how did you do this? I uninstalled it, then removed the repo, afterwards i added the repo and tried to install it again, but it couldn't finish the load. I changed my ressources from weather-card-chart to weather-chart-card and my ui-lovelace.yaml, but the card is no showing.

artemyevav commented 3 years ago

Try using my fork to see where the problem is: https://github.com/artemyevav/weather-chart-card

gdreelin commented 3 years ago

It is now working again on this repo so all good now.

yan14 commented 3 years ago

It is now working again on this repo so all good now.

it doesn't work for me neither. How did you get it to work?

gdreelin commented 3 years ago

@yan14 I close the HA window, cleared all the cache and closed out browser. Once I opened it back up it was all good.

Spirituss commented 3 years ago

After upgrade to 1.0.2 it still doesn't work

gdreelin commented 3 years ago

I had to completely remove Yevgenium version, clear cache, reboot. Once that is done I just reinstalled it and it started working with all the new chart info. I just did the update and it is still working great.

carvalr commented 3 years ago

I had to completely remove Yevgenium version, clear cache, reboot. Once that is done I just reinstalled it and it started working with all the new chart info. I just did the update and it is still working great.

I did the same and it works perfectly.

X1pheR commented 2 years ago

me too. it works now so this can be closed I guess.