search

Yevgenium / weather-chart-card

Custom weather card with charts
MIT License
275 stars 81 forks source link

Optional sensors #73

Closed brandondb1 closed 2 years ago

brandondb1 commented 3 years ago

Hey, thanks for updating this! It looks better than ever.

In the old version, and now in the new version, I've added the option to define humidity and pressure sensors as well (I have a BME 280 sensor outdoors, so I get temp, pressure and humidity)).

Unfortunately I can't seem to make the code work to default to the weather data if they aren't defined...i..e they come up blank if not defined in the card setup yaml.

I don't know if anyone else would see that as useful...if not I'm OK with what I have. If yes, I have it working minus the default to weather data and could share that with you.

Yevgenium commented 3 years ago

In the new version it will be possible to display data from humidity and pressure sensors. If someone considers it necessary, I can add the ability to use sensors for direction and wind speed.

Yevgenium commented 3 years ago

I always read the release notes for the new version of Home Assistant, but I didn't know that this component was added. It looks like we don't need sensor support in the weather card.

brandondb1 commented 3 years ago

Cool. I hadn't seen that either. What a great idea! Also, yes, means no need to rebuild the card to accomodate sensors.

I guess if it's a template it's perhaps also possible to have multiple options for the same variable selected based on availability so there's a 'fail safe' option if your local sensor fails.

On Wed., Sep. 1, 2021, 13:11 Yevgeniy Prokopenko, @.***> wrote:

I always read the release notes for the new version of Home Assistant, but I didn't know that this component https://www.home-assistant.io/integrations/weather.template/ was added. It looks like we don't need sensor support in the weather card.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Yevgenium/weather-chart-card/issues/73#issuecomment-910484422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7MZBZLYB44SPI2UQULFMLT7ZNCZANCNFSM5DAM4B2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yevgenium commented 3 years ago

Yes. And we will not see different information about temperature / humidity / etc. on the card and in the more info window, which I did not like and which could confuse new users.