Yevgenium / weather-chart-card

Custom weather card with charts
MIT License
275 stars 81 forks source link

Changes when Imperial Units? #85

Open mwolter805 opened 2 years ago

mwolter805 commented 2 years ago

Hello, Great card! Especially for a minimalist-themed dashboard. Would like to request a few enhancements for the Yankees.

Appears the rain graph range is calibrated for metric units? As you can see from the screenshot below. We are expecting 1.1 inches (28mm) of rain tomorrow but the graph is quite low. For us in California, this is an incredible amount! Screen Shot 2021-12-23 at 4 57 44 PM

Also, does the temperature portion of the graph self-adjust? 64.4f (18c) is quite low but it looks like it's going to be hot.

One last nitpicking thing, can the temp decimals be removed and the temp centered? Looks like it needs to be nudged a little to the right and decimals for temperature aren't really necessary for freedom units. The decimals take space and make the graph busy. Screen Shot 2021-12-23 at 4 58 17 PM

Ok, final thing, promise. It would be great to have the option to show the chance of precipitation percentage instead of the amount of rain prediction values at the bottom. Since the amount of rain is already displayed as a graph, doesn't seem necessary to have the actual values shown also. Would be great to see the prediction percentage in its place.

Thanks!

backcountrymountains commented 2 years ago

I'm wondering if we couldn't make the card more general by specifying which graphs have what information.

What if we just gave weather card a mapping of values to make the card more customizable? Like: Line1: tempHi Line2: tempLo Bar: precip Label: precipitation_probability

That way we could also make a separate chart that was just wind and precipitation and cloud cover or whatever other weather data we wanted to visualize. Like: Line1: precipitation_probability Line2: cloud_cover Bar: wind_speed Label: wind_bearing

Great card! Thanks for making it!

Hey @mwolter805, what's your weather source? I'd like to get my precipitation in freedom units like you, but openweathermap gives me mm instead of inches. It seems like their format gives precip in mm no matter what units you ask for.

Yevgenium commented 2 years ago

Appears the rain graph range is calibrated for metric units? As you can see from the screenshot below. We are expecting 1.1 inches (28mm) of rain tomorrow but the graph is quite low. For us in California, this is an incredible amount!

Should be fixed in 1.2.0

Also, does the temperature portion of the graph self-adjust? 64.4f (18c) is quite low but it looks like it's going to be hot.

The chart shows the change in temperature for the near future. The range of the scale automatically adapts to better represent the trend.

One last nitpicking thing, can the temp decimals be removed and the temp centered? Looks like it needs to be nudged a little to the right and decimals for temperature aren't really necessary for freedom units. The decimals take space and make the graph busy.

Actually the text inside the labels is centered. It may seem that it is shifted due to the degree symbol on the right. Despite this, I believe that the units of measurement should be present on the chart.

I initially tried using only integers in the chart labels. It looks strange on charts with a small temperature range, when we see that several labels with the same values ​​are located above or below each other. In this example, all labels will be image

tafypz commented 2 years ago

One more ask on imperial units, could you allow for wind speed in mph as well (miles per hour) in the units section ?