#14: Add support for .NET 4.6.1+ (WIP)

Ygg01 / Linguini

C# Port of fluent.rs zero-copy parser

Apache License 2.0

28 stars 8 forks source link

#14: Add support for .NET 4.6.1+ (WIP) #15

Closed mtkennerly closed 2 years ago

mtkennerly commented 2 years ago

dotnet build is working (with 10 warnings), but dotnet test is failing:

Failed!  - Failed:    22, Passed:    56, Skipped:     0, Total:    78, Duration:  - Linguini.Syntax.Tests.dll (net461)
Failed!  - Failed:    52, Passed:  3932, Skipped:     0, Total:  3984, Duration:  - Linguini.Bundle.Test.dll (net461)

I'm not sure yet if I messed something up or if it's an issue with the polyfills. I'll try to do some more digging, but I figured I would go ahead and open this as a draft to get your thoughts.

Ygg01 commented 2 years ago

Ok off the bat, I would aim to support net4.6.1 as an additional target, using conditional references to work with 4.6.1

As for the errors, your re-implementation of Syntax method doesn't work. If syntax is wrong, so is everything else.

mtkennerly commented 2 years ago

Closing in favor of https://github.com/Ygg01/Linguini/pull/16.