Yggdroot / indentLine

A vim plugin to display the indention levels with thin vertical lines
MIT License
4.14k stars 227 forks source link

AutoResetWidth breaks exclude options #301

Closed lukas-reineke closed 4 years ago

lukas-reineke commented 4 years ago

s:AutoResetWidth() checks enable from both buffer and global indentLine_enabled variable. https://github.com/Yggdroot/indentLine/blob/15aceda8c4eea621b66faa8673fca0b9fbe2f457/after/plugin/indentLine.vim#L268-L272

And then writes this value to the buffer indentLine_enabled variable. https://github.com/Yggdroot/indentLine/blob/15aceda8c4eea621b66faa8673fca0b9fbe2f457/after/plugin/indentLine.vim#L280

This breaks excluded filetypes/buftypes/bufnames because all buffers are now explicitly enabled and skip the filter. https://github.com/Yggdroot/indentLine/blob/15aceda8c4eea621b66faa8673fca0b9fbe2f457/after/plugin/indentLine.vim#L326

polyzen commented 4 years ago

Seems this is fixed in general, though I still have issues with indentLine exclusions not working in Terminal-Normal mode (buftype=terminal, filetype=) and when viewing commits that were pulled with vim-plug (buftype=git, filetype=nofile).

Edit: Perhaps related to #276.

lukas-reineke commented 4 years ago

fixed in https://github.com/Yggdroot/indentLine/pull/311