Ygoproco / Live

Instant update files for Ygopro Percy
https://www.ygopro.co
6 stars 14 forks source link

fix "When an opponent's monster declares an attack" conditions #499

Closed Shad3Light closed 8 years ago

Shad3Light commented 8 years ago

List of Fixed Cards:

Malevolent Catastrophe Prepare to Strike Back Chaos Burst Storming Mirror Force Rainbow Path Superheavy Samurai Blowtorch Depth Amulet D - Fortune Kid Guard Koa'ki Meiru Shield Negate Attack Archfiend Interceptor Dark Mirror Force Radiant Mirror Force Jam Defender A Hero Emerges Fairy Box Battle Break Insect Neglect Changing Destiny Poseidon Wave Security Orb Lucky Punch Roulette Spider Kunai with Chain Relieve Monster Ordeal of a Traveler Sandstorm Mirror Force Draining Shield Mirror Gate Dimension Gate Mirror Force Pinpoint Guard Double Defender Spell Recycler Heroic Challenger Vivid Knight Spider Egg Roar of the Earthbound Lumenize Shift Memory of an Adversary Reanimation Wave Darkness Neosphere Battle Instinct Justi-Break Armor Ninjitsu Art of Freezing Call of the Earthbound Dimension Wall Confusion Chaff Amazoness Archers Dimensional Prison Slip of Fortune Butterflyoke Offering to the Immortals Dice-Roll Battle Blackwing - Backlash Blast Held by a Tribute Cybernetic Hidden Technology Staunch Defender Dragonox, the Empowered Warrior Magical Arm Shield Enchanted Javelin Aqua Armor Ninja Barrier Wave Supercharge Last Resort Scrap-Iron Scarecrow Red Mirror Performapal Fireflux Dark Sanctuary Number 38: Hope Harbinger Dragon Titanic Galaxy Spiritual Swords of Revealing Light The Forceful Checkpoint

Percival18 commented 8 years ago

What problem does this fix?

edo9300 commented 8 years ago

it fixes a big problem, all of these cards, don't check whose monster attack, they only check who is the turn player, with this fix now they check the controler of the attacking monster instead of the turn player, like they should already do

Shad3Light commented 8 years ago

What @edo9300 said. While the current condition of these cards Duel.GetTurnPlayer()~=tp hasn't made any problem so far, it means "During your opponent's turn". It holds a different meaning from "When an opponent's monster declares an attack". By the wording, they should check for the controller of the attacker instead.