search

Ygoproco / Live

Instant update files for Ygopro Percy
https://www.ygopro.co
6 stars 14 forks source link

Added all VJump new cards #504

Closed EerieCode closed 8 years ago

LorisC93 commented 8 years ago

Take a look at what I've done in my closed pull for "Neo Galaxy-Eyes Cipher Dragon", I may be useful to simplify your version. I've seen that you have put a lot of conditions on the target part and I think it can be done without them.

EerieCode commented 8 years ago

You're right, that's a lot more efficient! Thank you! Give me a few minutes and I'll upload the new version.

EerieCode commented 8 years ago

Ok, with this it still works and it's more efficient and elegant. Thanks again!

LorisC93 commented 8 years ago

Nice! After all we are here to help each other! To the next time!

kenpazaraki commented 8 years ago

OMK Gun's 1st effect doesn't seem to work. No idea why, though.

EerieCode commented 8 years ago

Weird, that's the first card I've tested. Does it give an error message? Did you take battle or effect damage?

kenpazaraki commented 8 years ago

No error message, sorry. It doesn't work with battle damage, idk about effect damage. Also, Ancient Gear Gadget has an error at line 100, there was a message about a nil value or something.

EerieCode commented 8 years ago

I'll doublecheck OMG Gum, but "Ancient Gear Gadget"'s issue is literally impossible: it doesn't even have a line 100! Look at it, it ends at 95!

kenpazaraki commented 8 years ago

Lol. Maybe the error message had something to do with the AI.

kenpazaraki commented 8 years ago

Found out what the problem was. It was actually line 100 In Ancient Gear Hydra's script screenshot 79

EerieCode commented 8 years ago

In that case, I think I've already found what the problem is: the patch I've just uploaded should take care of it. Thanks!