search

YiC200333 / XConomy

An economy plugin that supports data synchronization between multiple servers
GNU General Public License v3.0
95 stars 33 forks source link

XConomy raping the server thread on multi instance #78

Closed LuluxClient closed 1 year ago

LuluxClient commented 1 year ago

Version of XConomy
XConomy V2.19.5

Server version
PufferFish 1.19.2

Storage-type
MySQL

Describe the issues
Server is often crashing du to Xconomy raping the server by using 23423432 threads on a multi instance server (2 proxies and 2 servers with mysql linked to Xconomy and nothing on the proxy which is Velocity)

(option)XConomy's config.yml Private (option)Screenshots Errors: https://pastebin.com/HFsRbjqE Crash report: https://we.tl/t-wQHIvSWDSh

YiC200333 commented 1 year ago

you can set ‘disable-async’ to true in the database.yml

LuluxClient commented 1 year ago

you can set ‘disable-async’ to true in the database.yml

will it fix the issue ? and also i got that : https://pastebin.com/epbGn6y2 and that; https://pastebin.com/0cf7kd5P

LuluxClient commented 1 year ago

and it keeps doing thread dumps and lagging the server a shit ton

LuluxClient commented 1 year ago

Yep disabling async is killing my server doing 435345 thread dumps and crashing after 20 players...

LuluxClient commented 1 year ago

If it can help with async off: https://spark.lucko.me/8y0iIxLA45 and new errors: https://pastebin.com/dJAefsD8

YiC200333 commented 1 year ago

https://github.com/YiC200333/XConomy/releases/tag/2.20.2 Try 2.20.2 version, this version require to regenerate database. yml

YiC200333 commented 1 year ago

You can set the Max_Thread number in database.yml if still has problem, give me feedback again

LuluxClient commented 1 year ago

You can set the Max_Thread number in database.yml if still has problem, give me feedback again

Hey I4ll try after a schedule restart / crash and thanks a lot !

LuluxClient commented 1 year ago

Got this when enabling it and deleting the database.yml https://pastebin.com/bTD0yfuA . Do I need to add the redis settings ?

LuluxClient commented 1 year ago

Got this when enabling it and deleting the database.yml https://pastebin.com/bTD0yfuA . Do I need to add the redis settings ?

Because I was wondering if redis could fix some syncro issues we are getting due to not having xconomy on our proxy (we have 2 velocity proxies) what do you reckon we should do to fix that ?

YiC200333 commented 1 year ago

Got this when enabling it and deleting the database.yml https://pastebin.com/bTD0yfuA . Do I need to add the redis settings ?

Can u send me your database.yml? There is no this problem in my test

YiC200333 commented 1 year ago

Got this when enabling it and deleting the database.yml https://pastebin.com/bTD0yfuA . Do I need to add the redis settings ?

Because I was wondering if redis could fix some syncro issues we are getting due to not having xconomy on our proxy (we have 2 velocity proxies) what do you reckon we should do to fix that ?

Yes, u can set cache-type to Redis to support sync data between velocity proxies

LuluxClient commented 1 year ago

Perfect, do I need to import data or I can keep my MySQL database and just add a redis database. Do I need to add the plugin on the proxy ?

Le lun. 31 oct. 2022 à 05:06, 伊C @.***> a écrit :

Got this when enabling it and deleting the database.yml https://pastebin.com/bTD0yfuA . Do I need to add the redis settings ?

Because I was wondering if redis could fix some syncro issues we are getting due to not having xconomy on our proxy (we have 2 velocity proxies) what do you reckon we should do to fix that ?

Yes, u can set cache-type to Redis to support sync data between velocity proxies

— Reply to this email directly, view it on GitHub https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296511817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMC2IWFDEOAQ5UBU2JLWF5AU5ANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.***>

YiC200333 commented 1 year ago

Redis is just a cache, The player data is still stored on Mysql. If enble Redis cache, u do not add the plugin on the proxy

YiC200333 commented 1 year ago

However, in the current version, this method can only synchronize data without message

LuluxClient commented 1 year ago

Wym by that ?

Le lun. 31 oct. 2022 à 07:27, 伊C @.***> a écrit :

However, in the current version, this method can only synchronize data without message

— Reply to this email directly, view it on GitHub https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296597507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.***>

YiC200333 commented 1 year ago

Wym by that ? Le lun. 31 oct. 2022 à 07:27, 伊C @.> a écrit : … However, in the current version, this method can only synchronize data without message — Reply to this email directly, view it on GitHub <#78 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.>

Yes, there is no cross server transfer message

LuluxClient commented 1 year ago

It’s fine then if it’s just the messages, the #1 thing is if the money is well synced between servers and if Player1 receives money On ServerA while he is on ServerB that would be awesome

Le lun. 31 oct. 2022 à 08:44, 伊C @.***> a écrit :

Wym by that ? Le lun. 31 oct. 2022 à 07:27, 伊C @.

> a écrit : … <#m-8426320430928463463> However, in the current version, this method can only synchronize data without message — Reply to this email directly, view it on GitHub <#78 (comment) https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296597507>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.>

Yes, there is no cross server transfer message

— Reply to this email directly, view it on GitHub https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296713056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMDVDUQRAEUFOIMACJTWF52EDANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.***>

YiC200333 commented 1 year ago

This can be done，Did you solve the error you sent me yesterday?

LuluxClient commented 1 year ago

lol try everything today and close it if it’s fixed Le lun. 31 oct. 2022 à 09:16, 伊C @.***> a écrit :

It’s fine then if it’s just the messages, the #1 https://github.com/YiC200333/XConomy/issues/1 thing is if the money is well synced between servers and if Player1 receives money On ServerA while he is on ServerB that would be awesome Le lun. 31 oct. 2022 à 08:44, 伊C @.

> a écrit : … <#m-2110920338700236188> Wym by that ? Le lun. 31 oct. 2022 à 07:27, 伊C @. > a écrit : … <#m-8426320430928463463> However, in the current version, this method can only synchronize data without message — Reply to this email directly, view it on GitHub <#78 https://github.com/YiC200333/XConomy/issues/78 (comment) <#78 (comment) https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296597507>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ https://github.com/notifications/unsubscribe-auth/AO5NOMAQY4C6IKOQQP4KFA3WF5RF5ANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.> Yes, there is no cross server transfer message — Reply to this email directly, view it on GitHub <#78 (comment) https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296713056>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMDVDUQRAEUFOIMACJTWF52EDANCNFSM6AAAAAARSKQCMQ https://github.com/notifications/unsubscribe-auth/AO5NOMDVDUQRAEUFOIMACJTWF52EDANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.>

This can be done，Did you solve the error you sent me yesterday?

— Reply to this email directly, view it on GitHub https://github.com/YiC200333/XConomy/issues/78#issuecomment-1296745059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMCNEVYWYJVRCTFSQF3WF557TANCNFSM6AAAAAARSKQCMQ . You are receiving this because you authored the thread.Message ID: @.***>

LuluxClient commented 1 year ago

This can be done，Did you solve the error you sent me yesterday?

Still not fixed: https://we.tl/t-al3Qp4cIi2 config: https://mcpaste.io/b37860dd96cec408

LuluxClient commented 1 year ago

When using "usepool: true" on true I'm getting this error: https://pastebin.com/0VpBr7ai and after putting it on false no more error

Thread dump: https://pastebin.com/aTkhsJYT

small performance issue which is lagging / slowing down other plugins: https://spark.lucko.me/9wUNosHFU1

YiC200333 commented 1 year ago

https://github.com/YiC200333/XConomy/releases/tag/2.20.3

Try setting a smaller value in ”max-threads“, such as 5 I fix the error when using "usepool: true" in 2.20.3 version.

LuluxClient commented 1 year ago

https://github.com/YiC200333/XConomy/releases/tag/2.20.3

Try setting a smaller value in ”max-threads“, such as 5 I fix the error when using "usepool: true" in 2.20.3 version.

The changes helps a lot but I'm getting this and it often kicks players and freeze the server for a min: https://pastebin.com/gFVEu53r

YiC200333 commented 1 year ago

I'm a little busy this week. I'm late to reply. I fix it in this version https://github.com/YiC200333/XConomy/releases/tag/2.20.4