search

YiFei2 / pe

0 stars 0 forks source link

Case insensitive company name saved in event list #4

Open YiFei2 opened 2 years ago

YiFei2 commented 2 years ago

image.png

Similar to previous issue, the company name saved to event list retains its upper-cased letters.

soc-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

When adding event/person, it is allowed to use company' name with different cases(upper/lower), this fails to remove the event/person associated to the company when the company is deleted

Reproduce the bug:

  1. `addc n/ByteDance t/bank e/bytedance@protonmail.com p/1234567 a/31 Race Card Road

    02-03 t/tech`

  2. adde n/Interview c/Bytedance d/2022-04-02 ti/14:00 l/Zoom this command is valid and being executed, note that even though "ByteDance" is being typed as "Bytedance", and there is no company called "Bytedance" in the current list of companies
  3. listc
  4. delete 10 where 10 is the index of "ByteDance" during testing

Expected outcome:

  1. Company "ByteDance" is deleted
  2. Event "Interview " which is associated to "ByteDance" is deleted

Actual outcome:

  1. Company "ByteDance" is deleted
  2. Event "Interview " which is associated to "ByteDance" is not being deleted, because in it the company is called "Bytedance"

image.png Note that the details in the screenshot is different from the one in bug report, however it serves the same purpose.

[original: nus-cs2103-AY2122S2/pe-interim#2602] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Reason for Changing to Medium: We accept that the bug is present. However, the application can still be used (it does not cause major problem for the users). It will cause some convenience (deleting the persons and events related to the deleted companies one by one). However, the application will still be useable.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Medium] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]