search

YiFei2 / pe

0 stars 0 forks source link

Unarchive_all command does not work when list has both archived and unarchived entries #9

Open YiFei2 opened 2 years ago

YiFei2 commented 2 years ago

image.png

As seen in the image, when a later entry is archived, the unarchive_all command is unable to unarchive that entry.

soc-se-bot commented 2 years ago

Team's Response

This is the intended behavior. Not an issue.

InternBuddy gives error message when you unarchive an unarchived entry. Therefore, the behaviour that InternBuddy gives error message when you unarchive_all with unarchived entries mixed in the list is consistent.

Plus the archive commands acts a improving users' quality of life. It is an extension to the main parts of InternBuddy.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is unclear from the UG what the intended behaviour of the unarchive_all and archive_all commands are for mixed lists. In the original case, unarchive_all returns an error immediately as the first entry is unarchived. However, if the first few entries are archived, the unarchive_all command will actually return an error but still successfully unarchive the first few meetings, which seems to be inconsistent behaviour from the original case.

image.png

Users may be led to believe from this error message that the unarchive_all command will not work for mixed lists, and proceed to attempt to unarchive the company individually. This causes a bug where the list does not update the archival status of the company even though it is unarchived, hence the unarchive 1 command in the next screenshot returns an error although it is still archived.

image.png

I believe that similar bugs arise from the archive_all command. The screenshot below is running archive 2 after archive_all command with the last company in the list being archived.

image.png

As the app is shown to have visual inconsistencies, this leads me to believe that the team did not consider the behaviour of archive_all and unarchive_all for mixed lists with companies with both archival status. If it is intended behaviour, the list should update accordingly.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I believe the severity to be medium as it is within normal user behaviour to utilize the archive_all and unarchive_all commands on a mixed list and the bug does cause an occasional inconvenience. Regardless of if the features are only extensions to the main parts of the app, the features are still provided and hence will be utilized by users.