YiannisBourkelis / Andama-Remote-Desktop

Andama is an open source remote desktop software, with client side encryption and privacy in mind
GNU General Public License v3.0
59 stars 47 forks source link

Add 18 new virtual-keys and support for them on Linux #17

Closed shiftee closed 7 years ago

shiftee commented 7 years ago

This PR adds support for keys needed to edit scripts and C/C++ code remotely.

I picked key values that seemed to be unused, let me know if they should be changed.

This should probably be tested to make sure it does not break other operating systems

YiannisBourkelis commented 7 years ago

@shiftee I used the virtual key codes from windows based on this link: https://msdn.microsoft.com/en-us/library/windows/desktop/dd375731(v=vs.85).aspx (Virtual-Key Codes) With your modifications do these special keys work well on linux? Have you tested them?

shiftee commented 7 years ago

I have tested the new keys and they all work from one Ubuntu machine to another.

Someone should test the changes on windows/mac to check nothing is broken. I imagine it wouldn't be difficult to add support for the new keys on mac, not sure about windows

YiannisBourkelis commented 7 years ago

@shiftee ok I will merge the pr and add a todo for windows and OS X to ignore these special keys at the moment.

shiftee commented 7 years ago

Thanks