search

Yiheng0410 / pe

0 stars 0 forks source link

Delete every person from a group, use remove better? #6

Open Yiheng0410 opened 3 years ago

Yiheng0410 commented 3 years ago

I thought it will delete all the persons assigned to a particular group, however, after test the command, it only remove all person from the group. So I think it is better to use remove all person from a group rather than delete, because delete sounds like you are going to delete the person from the app.

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Usecase Delete All person from group

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Extension show that this function is supposed to remove people from that group and not deleting the person from that group.

Hence the statement is logically flaw.

delete all person in that group !== removing person from that group.

As I thought that this function would delete the person from addressbook belonging to the addressbook itself.

image.png

[original: nus-tic4002-AY2021S2/pe-interim#51] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The documentation description is correct. It clearly states that it will delete, hence remove all person from the group. It did not state that it will delete all person in that group from the App.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: According to the Dev team's description in the UG, the 'delete' is actually refer to 'remove'.

I still think use remove as command word or key word is better than delete because it avoids ambiguity. From a user's perspective, delete means delete permanently from the app, however, what dev team's implemented is just to remove user temporally from the group and they can be reassigned to other groups if needed.