Yikai-Liao / symusic

A cross platform note level midi decoding library with lightening speed, based on minimidi.
https://yikai-liao.github.io/symusic/
MIT License
108 stars 8 forks source link

Fixing lint, Soundfont `md5` renamed `hash_` (and using sha384) #42

Closed Natooz closed 1 month ago

Natooz commented 1 month ago

This PR fixes the code linting, while adding a few additional ruff rules with the associated fixes in the code. It results in a lot of automatically made code changes, which for the most doesn't really change the code executions (except things Path related but for the best). Also the Soundfont.md5 attribute is renamed hash_ (to be more general, and with a _ to not overshadow the building python "hash" method) as the hash method is changed to sha384 (arbitrary chosen but other secure algorithms can be chosen) to comply with the "S" (security) ruff rule.

It doesn't fixes the tests (discussed in #32) for now. Ready to be merged on my end, build is working on macOS arm64.