YimMenu / HorseMenu

HorseMenu, a beta-stage mod menu for Red Dead Redemption 2 and Red Dead Online, inspired by YimMenu, that protects against crashes and enhances your experience.
76 stars 37 forks source link

Many Features + Protections #116

Closed Rxann closed 6 months ago

Rxann commented 8 months ago

Adds hunter wagon spawning, fixes some stuff, adds caging and circusing. adds protection for these also. adds horse scale adjustment and flaming hooves for your horse. this would not be possible without @tyackman

Deadlineem commented 8 months ago

This is going to be a solid update imo i like the cage options and the flaming hooves!

github-actions[bot] commented 8 months ago

Download the artifacts for this pull request:

Rxann commented 8 months ago

Fixed hat issue that caused caging to be inefficient/ineffective

Rxann commented 7 months ago

There are natives for locking vehicle doors, not sure if this cage door can be locked or not, but i remember when we were testing this i was able to casually walk out of the wagon cage.

Ref:

VEHICLE::SET_VEHICLE_INDIVIDUAL_DOORS_LOCKED

void SET_VEHICLE_INDIVIDUAL_DOORS_LOCKED(Vehicle vehicle, int doorId, int doorLockStatus) // 0xA9F1D75195CC40F6 0xD61D182D b1207

doorId: see SET_VEHICLE_DOOR_SHUT

I doubt this would work because it is for a vehicle and there wouldn't be registered doors on a cage

Rxann commented 7 months ago

There are natives for locking vehicle doors, not sure if this cage door can be locked or not, but i remember when we were testing this i was able to casually walk out of the wagon cage.

Ref:

VEHICLE::SET_VEHICLE_INDIVIDUAL_DOORS_LOCKED

void SET_VEHICLE_INDIVIDUAL_DOORS_LOCKED(Vehicle vehicle, int doorId, int doorLockStatus) // 0xA9F1D75195CC40F6 0xD61D182D b1207

doorId: see SET_VEHICLE_DOOR_SHUT

I tested and I was unable to reproduce the being able to walk out of the wagon

Rxann commented 6 months ago

@MarkEcza could you merge this as well because it already has approval?

MarkEcza commented 6 months ago

@MarkEcza could you merge this as well because it already has approval?

If there are no false flagging with the models you've added and everything works fine i will merge it. Edit: Can you fix the conflict in Self.cpp?

Rxann commented 6 months ago

@MarkEcza could you merge this as well because it already has approval?

If there are no false flagging with the models you've added and everything works fine i will merge it.

Edit: Can you fix the conflict in Self.cpp?

Thank you so much, and I will mention you in this pr once the conflicts are resolved in a few hours. And, I have tested this extensively and there are no false positives.

Rxann commented 6 months ago

@MarkEcza conflicts have been resolved