YimMenu / HorseMenu

PRE-ALPHA Shaping up, star trek aint got nothing on this
39 stars 21 forks source link

[Bug]: Red Dead Crashes After DLL Injection on Vulkan #158

Open ms-william opened 3 days ago

ms-william commented 3 days ago

Describe the bug

Well, some time ago, I had already reported this in an issue report. Basically, my game crashes when injecting the DLL while using Vulkan (the game runs much smoother with Vulkan than with DX12). I would like to know if there will ever be a solution for this.

Steps To Reproduce

  1. Launch the game with default settings (Vulkan)
  2. Inject the DLL file (I tried with different injectors).
  3. Games crash...

Expected Behavior

The game crashes only when injecting the DLL in Vulkan mode. Without DLL injection, the game runs normally. If I try to inject using DirectX 12 the game doesn't crash but as I said, in terms of performance on my PC in Vulkan the game runs much better

Logs and/or screenshots

[cout.log](https://github.com/user-attachments/files/16092075/cout.log)

Store

Steam

Language

English

Additional context

No response

Build

maybegreat48 commented 3 days ago

Do you have an AMD GPU?

ms-william commented 3 days ago

Do you have an AMD GPU?

Yes

Rxann commented 3 days ago

I believe it is an AMD gpu issue

ms-william commented 2 days ago

Maybe... It could be, but it's kind of sad to do what. What I want to say about DirectX 12 is that in some places it takes a while to render, I don't know how to explain it, even though my PC is powerful this happens in RDR2 and in a few situations the FPS seems a little lower, I mean when it comes to FPS 1 % LOW, why the avg. fps is good. I hope it's not a problem with the gpu but rather how the dll behaves when injecting...

FIying-Scotsman commented 2 days ago

Maybe... It could be, but it's kind of sad to do what. What I want to say about DirectX 12 is that in some places it takes a while to render, I don't know how to explain it, even though my PC is powerful this happens in RDR2 and in a few situations the FPS seems a little lower, I mean when it comes to FPS 1 % LOW, why the avg. fps is good. I hope it's not a problem with the gpu but rather how the dll behaves when injecting...

There's something weird about AMD's Vulkan implementation at the driver level (this hasn't been an issue on Nvidia cards). There's been reports as far back as 2020 from AMD card users crashing in games when using Vulkan for example. It's still a problem today, with a common fix being "update your drivers" but you also have to remember AMD has representatives in game studios for issues like this. Community projects are left to their own devices.

I mention this because it's unfortunately not an easy fix, especially given big name games are having similar issues with their Vulkan implementations but unlike Horsemenu - they're paying devs to work on it. This is a hobby so unless someone with a lot of knowledge comes out the fog and has a better idea, unfortunately it looks like DX12 is the only way to use Horsemenu on AMD in the mean time and it's purely because of something they're doing in their driver (which is out of our control).

Friuuu commented 1 day ago

AMD gpus and RDR2 do not get along very well. Vulkan overall seems pretty unstable on amd gpus (I have rx590) and dx12 on rdr2 does not work perfectly either. When using dx12 I have this damn fog problem that has been around for a while (image borrowed from internet). strange-fog-rectangle-on-the-side-of-my-screen-how-do-i-get-v0-8ow94vn70mnc1

ms-william commented 1 day ago

AMD gpus and RDR2 do not get along very well. Vulkan overall seems pretty unstable on amd gpus (I have rx590) and dx12 on rdr2 does not work perfectly either. When using dx12 I have this damn fog problem that has been around for a while (image borrowed from internet). strange-fog-rectangle-on-the-side-of-my-screen-how-do-i-get-v0-8ow94vn70mnc1

I didn't have this problem with fog using DirectX 12, my problem is more with some places that "take" a little longer to render. I have a 6700 XT and it works perfectly with Vulkan, I only use DX12 to use HorseMenu

imstash commented 1 day ago

AMD GPU's just have horrible fucking drivers and no one at AMD actually gives a fuck. NVIDIA maybe more expensive but they don't have bullshit issues like these.

Rxann commented 1 day ago

AMD GPU's just have horrible fucking drivers and no one at AMD actually gives a fuck. NVIDIA maybe more expensive but they don't have bullshit issues like these.

This is true.