search

YimMenu / YimMenu

YimMenu, a GTA V menu protecting against a wide ranges of the public crashes and improving the overall experience.
https://yim.gta.menu
GNU General Public License v2.0
1.27k stars 1.04k forks source link

[Bug]: Random invalid object model crash #1274

Closed Rxann closed 1 year ago

Rxann commented 1 year ago

Describe the bug

I was playing with my friend in online, we were driving around in circles and this just started printing to the console.

Steps To Reproduce

This is just what happened to me, I don't know if it was reproducible or random.

  1. Enter vehicle
  2. Drive with person(maybe) to outside of nightclub
  3. Drift

Expected Behavior

Not to occour

Screenshots and/or Logs

[16:11:53.6708758][INFO/main.cpp:62] Yim's Menu Initializing [16:11:53.6711852][INFO/main.cpp:63] Git Info Branch: master Hash: 530a798d6221f70d9c2f779a2704bd90a9519003 Date: Thu Apr 20 19:07:16 2023 [16:11:53.8198117][INFO/main.cpp:66] Translation Service initialized. [16:11:53.8198979][INFO/main.cpp:69] Thread pool initialized. [16:11:53.8202116][DEBUG/thread_pool.cpp:22] Allocating 8 threads in thread pool. [16:11:53.8293671][INFO/main.cpp:72] Settings Loaded. [16:11:53.8293645][DEBUG/thread_pool.cpp:87] Thread 8416 executing globals.cpp:18 [16:11:53.8351137][INFO/pointers.hpp:92] GTA5 pointers cache is up to date, using it. [16:11:53.8351436][INFO/pointers.cpp:1432] Loading pointers instance from cache [16:11:53.8351455][INFO/pointers.cpp:1441] Pointers cache: Loading 164 fields from the cache [16:11:53.8351713][DEBUG/module.cpp:50] Waiting for socialclub.dll... [16:11:53.8422105][INFO/pointers.hpp:92] Social Club pointers cache is up to date, using it. [16:11:53.8422242][INFO/pointers.cpp:1432] Loading pointers instance from cache [16:11:53.8422267][INFO/pointers.cpp:1441] Pointers cache: Loading 3 fields from the cache [16:11:53.8422757][INFO/main.cpp:75] Pointers initialized. [16:11:53.8423020][INFO/main.cpp:78] Byte Patch Manager initialized. [16:11:54.3267243][INFO/main.cpp:81] Renderer initialized. [16:11:54.5235763][INFO/main.cpp:85] Fiber pool initialized. [16:11:54.5357173][INFO/main.cpp:88] Hooking initialized. [16:11:54.5500488][DEBUG/gta_data_service.cpp:157] Loading data from cache. [16:11:54.5500777][INFO/gta_data_service.cpp:169] Loading 1016 peds from cache. [16:11:54.5504427][INFO/gta_data_service.cpp:187] Loading 793 vehicles from cache. [16:11:54.5506739][INFO/gta_data_service.cpp:205] Loading 116 weapons from cache. [16:11:54.5507249][DEBUG/gta_data_service.cpp:163] Loaded all data from cache. [16:11:54.5630225][INFO/main.cpp:106] Registered service instances... [16:11:54.5631207][INFO/main.cpp:126] Scripts registered. [16:11:54.6030714][INFO/main.cpp:129] Hooking enabled. [16:11:54.6031018][INFO/main.cpp:132] Dynamic native hooker initialized. [16:12:19.9079068][INFO/backend.cpp:40] Starting script: Self [16:12:19.9079270][INFO/backend.cpp:54] Starting script: Weapons [16:12:19.9079390][INFO/backend.cpp:73] Starting script: Vehicles [16:12:19.9079484][INFO/backend.cpp:101] Starting script: Miscellaneous [16:12:19.9079611][INFO/backend.cpp:119] Starting script: Remote [16:12:19.9079639][INFO/backend.cpp:134] Starting script: Ls customs [16:12:19.9079658][INFO/backend.cpp:146] Starting script: Rainbow paint [16:12:19.9079678][INFO/backend.cpp:158] Starting script: Vehicle fly [16:12:19.9079727][INFO/backend.cpp:89] Starting script: turnsignal [16:12:19.9079852][INFO/backend.cpp:170] Starting script: Disable Control Action [16:12:19.9079884][INFO/backend.cpp:183] Starting script: World [16:13:55.2557422][DEBUG/script_function.cpp:35] Found pattern SFSA in script freemode [16:16:14.8477205][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:14.9791441][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.0605046][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.1741090][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.2449691][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.3735777][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.5226563][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.6188515][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.7641522][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.8669941][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:15.9905434][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.0802309][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.1875288][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.2595008][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.3821816][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.4844955][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.5676586][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.6835186][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.7506740][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:16.8702455][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.0370070][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.1361504][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.2858465][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.4422037][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.5507804][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.6285881][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.7671625][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:17.9500327][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.0610500][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.2019952][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.2796767][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.4020647][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.5062631][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.6513498][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.8111930][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.9120403][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:18.9979053][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.1603600][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.3104797][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.4410609][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.5633598][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.6961012][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.8139936][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.9279549][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:19.9919944][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.1099767][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.2462003][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.4149743][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.5662336][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.7166134][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.8671240][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:20.9808374][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.1222684][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.2673472][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.3716274][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.4773034][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.6176247][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.7082143][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.8425246][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:21.9794847][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.1345045][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.2917509][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.4465352][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.5771580][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.6970408][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.7703635][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:22.9032320][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.0365560][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.1498566][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.2985614][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.4326990][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.5492207][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.7026173][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.8438066][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:23.9504241][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.0525259][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.1586106][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.3229587][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.4536685][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.5434499][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.6435513][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.7577040][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.8593022][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:24.9570542][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.0420915][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.1531247][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.2658962][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.3611661][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.4696266][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:16:25.5758405][WARN/notify.hpp:27] Blocked invalid object model crash from potatosquash14 (223492159) [16:33:49.5075027][WARN/reaction.cpp:25] Received Breakup Kicks On Other Players from angel8black (123052475) [16:46:59.4255876][INFO/main.cpp:140] Hooking disabled. [16:46:59.4257763][INFO/main.cpp:143] Dynamic native hooker uninitialized. [16:46:59.4261232][INFO/main.cpp:146] Scripts unregistered. [16:46:59.4261487][DEBUG/thread_pool.cpp:100] Thread 18268 exiting... [16:46:59.4261547][DEBUG/thread_pool.cpp:100] Thread 8436 exiting... [16:46:59.4261516][DEBUG/thread_pool.cpp:100] Thread 16200 exiting... [16:46:59.4261656][DEBUG/thread_pool.cpp:100] Thread 2720 exiting... [16:46:59.4261975][DEBUG/thread_pool.cpp:100] Thread 17744 exiting... [16:46:59.4262416][DEBUG/thread_pool.cpp:100] Thread 18292 exiting... [16:46:59.4263331][DEBUG/thread_pool.cpp:100] Thread 8164 exiting... [16:46:59.5184033][DEBUG/thread_pool.cpp:100] Thread 8416 exiting... [16:46:59.5190333][INFO/main.cpp:154] Destroyed thread pool. [16:46:59.5190766][INFO/main.cpp:158] Hotkey Service reset. [16:46:59.5190994][INFO/main.cpp:160] Matchmaking Service reset. [16:46:59.5193510][INFO/main.cpp:162] Player Database Service reset. [16:46:59.5193598][INFO/main.cpp:164] API Service reset. [16:46:59.5207424][INFO/main.cpp:166] Script Patcher Service reset. [16:46:59.5208000][INFO/main.cpp:168] Gui Service reset. [16:46:59.5220006][INFO/main.cpp:170] GTA Data Service reset. [16:46:59.5220141][INFO/main.cpp:172] Vehicle Service reset. [16:46:59.5220183][INFO/main.cpp:174] Model Preview Service reset. [16:46:59.5220762][INFO/main.cpp:176] Mobile Service reset. [16:46:59.5220816][INFO/main.cpp:178] Player Service reset. [16:46:59.5220849][INFO/main.cpp:180] Pickup Service reset. [16:46:59.5239227][INFO/main.cpp:182] Globals Service reset. [16:46:59.5239359][INFO/main.cpp:184] Custom Text Service reset. [16:46:59.5239564][INFO/main.cpp:186] Context Service reset. [16:46:59.5239584][INFO/main.cpp:187] Services uninitialized. [16:46:59.5239882][INFO/main.cpp:190] Hooking uninitialized.

Store

Steam

Additional context

No response

Build

iswaxan commented 1 year ago

might be promtheus one of the two crashes

Rxann commented 1 year ago

what does this mean?

rrAsus commented 1 year ago

I think this does sometimes happen when you try to spoof your model aswell.

Rxann commented 1 year ago

I wasn't spoofing my player model

ghost commented 1 year ago

sometimes I wonder if the collaborators of this menu actually play the game or just grief the shit out of others while they use it. i have only used this menu for protections and customizing vehicles you can't normally customize (like pegasus aircraft before adding them to a hanger). this error happens for no reason during regular gameplay. i've seen it myself constantly for months now. same thing with other crashes and broken mission behavior. it's not an attack. it's a false positive. i won't even use this menu anymore since it's so far gone and buggy. i test it and see nothing's changed and then it goes right back to not getting used. you guys going to start taking false positives and bugs and crashes serious for once?

xiaoxiao921 commented 1 year ago

sometimes I wonder if the collaborators of this menu actually play the game or just grief the shit out of others while they use it. i have only used this menu for protections and customizing vehicles you can't normally customize (like pegasus aircraft before adding them to a hanger). this error happens for no reason during regular gameplay. i've seen it myself constantly for months now. same thing with other crashes and broken mission behavior. it's not an attack. it's a false positive. i won't even use this menu anymore since it's so far gone and buggy. i test it and see nothing's changed and then it goes right back to not getting used. you guys going to start taking false positives and bugs and crashes serious for once?

I think you forgot nobody is getting paid for this and we do this in our free time

ghost commented 1 year ago

sometimes I wonder if the collaborators of this menu actually play the game or just grief the shit out of others while they use it. i have only used this menu for protections and customizing vehicles you can't normally customize (like pegasus aircraft before adding them to a hanger). this error happens for no reason during regular gameplay. i've seen it myself constantly for months now. same thing with other crashes and broken mission behavior. it's not an attack. it's a false positive. i won't even use this menu anymore since it's so far gone and buggy. i test it and see nothing's changed and then it goes right back to not getting used. you guys going to start taking false positives and bugs and crashes serious for once?

I think you forgot nobody is getting paid for this and we do this in our free time

Ya'll love saying this but you're missing the point. I'm not asking you to work faster. I'm asking you to trust what folks are reporting.

edit: don't get me wrong. i'm a big fan of this menu. i'd love to keep using it but in its current state it makes the game work worse than if i didn't use it. please take a look at the bugs and reports asking for fixes with the assumption that folks are being genuine.

Yimura commented 1 year ago

Ya'll love saying this but you're missing the point. I'm not asking you to work faster. I'm asking you to trust what folks are reporting.

edit: don't get me wrong. i'm a big fan of this menu. i'd love to keep using it but in its current state it makes the game work worse than if i didn't use it. please take a look at the bugs and reports asking for fixes with the assumption that folks are being genuine.

I don't play the game at all, I've never played any missions (probably less than 50 overall). The only times I launch the game is to test new features or add new features. During which I'm just in freemode for several hours, during that time the menu is really stable.

You've also got to understand that some of the crashes people are reporting are really hard to reproduce since the log file is useless or not provided.

Recently there was this report about the game crashing when unloading, but I really can't reproduce it all. I unload it and my game doesn't crash, no idea how to reproduce it at all.

YimMenu is a very large code base and from time to time I invest time into rewriting and optimising certain parts of the code base and so does @xiaoxiao921 . Then there's @maybegreat48 who's an absolute godsend capable of fixing the most obscure crashes.

With every change we make we need to think about maintainability for the future, make sure it is usuable for others that work with the codebase and it doesn't cause any issues for people that merge upstream into their modified menu.

With the current issues, it might be a good idea looking into a rewrite where we implement every features step by step to see which one causes what sort of problems.

ghost commented 1 year ago

I agree. The crashes have been very difficult to reproduce. I would gladly troubleshoot the menu more if I thought my findings would be taken into account. I tried recreating the impact crashes in as repeatable a method I could all the way back in January but it didn't get any attention from what I could tell. So I gave up since it didn't appear anyone else cared and I'm not just going to keep submitting reports for the same thing. I don't care about many of the features of this menu except for the protections and logs but one thing I really care about is that it doesn't contribute to breaking the game. If a rewrite is considered would you and the collaborators consider a stable branch apart from the nightly? Or even a lite version without all the bloat? I don't know. Something to think about.

Rxann commented 1 year ago

The current release is somewhere around like 3.75 kb. kilobytes. I would consider this not bloated. Something that would theoretically be possible is that there is a stable branch and a nightly branch. I don't know what the main developers would think about this. Also, the code right now goes through a quite rigorous testing / review phase before it is merged. I have first hand experience, but this allows for only high quality and functional code to make it to the "nightly" branch. I would not consider the code in the "nightly" branch to be actually buggy due to the PR / review process and the very highly skilled developers such as @Yimura , @xiaoxiao921 , and @maybegreat48 .

tupoy-ya commented 1 year ago

If a rewrite is considered would you and the collaborators consider a stable branch apart from the nightly? Or even a lite version without all the bloat?

I think having 2 branches would be harder to maintain and we should just make stable releases instead. A lite branch seems almost impossible to maintain for a YimMenu sized project.

The current release is somewhere around like 3.75 kb. kilobytes. I would consider this not bloated.

The dll size doesn't mean much. What is bloat for me is:

  1. Useless features. (Subjective)
  2. Features that can be done in 1 line of Lua.
  3. Things that are to big for what they do, like cpr takes almost half the compile time while providing features that i never use.

Code in the master branch is buggy and the "review process" usually just looks at the code and doesn't actually test anything in game. Examples of stuff that was unnoticed:

  1. Hud color selection didn't save if i remember correctly, and can be done in 1 line of Lua.

  2. hooks::script_handler_is_networked crashes at the end of single player missions.

    bool hooks::script_handler_is_networked(CGameScriptHandler* _this)
{
-   return true;
+   return *g_pointers->m_gta.m_is_session_started;
}

    Seems to fix this, did not test a lot. EDIT: Seems to be related to #1026.

  3. Super jump. The last time i checked you just ragdoll when you fall down.

  4. SuperMan. The last time i checked it was impossible to control.

There are probably more, those were the ones i remember. These may not be correct as i don't use default YimMenu and don't play GTA Online a lot.

Rxann commented 1 year ago

Is

If a rewrite is considered would you and the collaborators consider a stable branch apart from the nightly? Or even a lite version without all the bloat?

I think having 2 branches would be harder to maintain and we should just make stable releases instead. A lite branch seems almost impossible to maintain for a YimMenu sized project.

The current release is somewhere around like 3.75 kb. kilobytes. I would consider this not bloated.

The dll size doesn't mean much. What is bloat for me is:

  1. Useless features. (Subjective)
  2. Features that can be done in 1 line of Lua.
  3. Things that are to big for what they do, like cpr takes almost half the compile time while providing features that i never use.

Code in the master branch is buggy and the "review process" usually just looks at the code and doesn't actually test anything in game. Examples of stuff that was unnoticed:

  1. Hud color selection didn't save if i remember correctly, and can be done in 1 line of Lua.
  2. hooks::script_handler_is_networked crashes at the end of single player missions.
bool hooks::script_handler_is_networked(CGameScriptHandler* _this)
{
- return true;
+ return *g_pointers->m_gta.m_is_session_started;
}

Seems to fix this, did not test a lot. EDIT: Seems to be related to #1026.

  1. Super jump. The last time i checked you just ragdoll when you fall down.
  2. SuperMan. The last time i checked it was impossible to control.

There are probably more, those were the ones i remember. These may not be correct as i don't use default YimMenu and don't play GTA Online a lot.

Does the script_handler_is_networked need to be updated? If so I can do that

Rxann commented 1 year ago

I do have the edits you made drafted and ready to make a pr, but please tell me if you want to open the PR yourself because you found this little bug that I could never in a million years find.

tupoy-ya commented 1 year ago

I do have the edits you made drafted and ready to make a pr, but please tell me if you want to open the PR yourself because you found this little bug that I could never in a million years find.

I wanted to make it myself but if you already have it you make the PR.

Rxann commented 1 year ago

By all means, you make it. You found it and you deserve that credit.

maybegreat48 commented 1 year ago

broken mission behavior

Can you elaborate? Most of the heist weirdness should be fixed

sometimes I wonder if the collaborators of this menu actually play the game

I have more fun developing than actually playing the game these days so I agree with your statement

Hud color selection didn't save if i remember correctly, and can be done in 1 line of Lua.

This was fixed recently

Rxann commented 1 year ago

Not going to lie, developing this( my very small contributions ) is more fun than the actual game.

ghost commented 1 year ago

broken mission behavior

Can you elaborate? Most of the heist weirdness should be fixed

I've already opened a bug issue on it. It's the one about preventing waves of npcs from spawning. I mention auto shop contracts but it affects many missions that involve sending npc waves at you while in transit, such as dax missions, agatha missions, etc. This bug is actually easy to reproduce, unlike the random crashes. Requirements are to a) not be host and b) join a mission with an npc wave. This only affects waves that don't have a fixed position, so waves that are set to intercept you anywhere on your drive to an objective.

edit: and if anyone cares here's a supercut of four impact crashes I was able to get a recording of back in January. Two of the crashes are in the same spot but this isn't guaranteed to happen. Three of them are on the same auto shop contract mission. The third one specifically I only nicked a road sign and the game crashed to desktop. And the one on the bike happened in freeroam. this crash right here is the main reason I can't use yimmenu anymore.

Yimura commented 1 year ago

I have added a check to the player model spoofing to check if the model actually exists so this issue should be mostly resolved, I haven't seen this notification popup in a while either so I think it's fixed.