search

YingZhou001 / Immuannot

Immuological gene typing and annotation for genome assembly
MIT License
31 stars 5 forks source link

searchTemplate.py script issue #9

Open vegetableyu opened 1 month ago

vegetableyu commented 1 month ago

Hi ying, These two segments of code: tmp = x0 x0 = y0 y0 = x0 and tmp = x1 x1 = y1 y1 = x1 are confusing me. It seems like tmp is not serving any purpose, and the output will make x0=y0/y1=x1. I don’t quite understand the role of this code during mergeInterval. Can you please explain it ? Thank you for your help! image

YingZhou001 commented 3 weeks ago

Sorry to get back to you lately. That should be a bug, thanks for reporting here. Should be fixed now.

yeeus commented 3 weeks ago

Sorry to get back to you lately. That should be a bug, thanks for reporting here. Should be fixed now.

Hi! I have used Immuannot to call HLA alleles. I'd like to know what this bug will cause? Would it have great effect on final results?

YingZhou001 commented 3 weeks ago

I think the effect should be very minor since our evaluation showed pretty high consistency with other methods. You may compare the difference between the early version (with this bug) and current version on some selected samples to see whether there is any significant difference in allele typing.

vegetableyu commented 3 weeks ago

Thank you so much for addressing and fixing the bug. Immuannot is an exceptional tool.