search

YingyiLiu / HAMS

An open-source computer program for the analysis of wave diffraction and radiation of three-dimensional floating or submerged structures
Apache License 2.0
100 stars 50 forks source link

Better regression #13

Closed gbarter closed 3 years ago

gbarter commented 3 years ago

This fixes some errors in the test script itself, but it has revealed further differences between new runs and the truth files (whether I use gfortran or ifort). This will take some more digging.

YingyiLiu commented 3 years ago

Just added a simple ifort make file for the source code compilation using ifort in Windows. It seems that the sequence of the source code files in the compilation is important, lower-level subroutines should be compiled first. I tested the cylinder case using the new executable file (HAMS_ifort_Win.exe), the results of the new run are the same as the benchmark results. But I've not yet tested in any Linux system using ifort.

Garrett Barter @.***> 于2021年5月22日周六 上午12:06写道：

This fixes some errors in the test script itself, but it has revealed further differences between new runs and the truth files (whether I use gfortran or ifort). This will take some more digging.

You can view, comment on, or merge this pull request online at:

https://github.com/YingyiLiu/HAMS/pull/13 Commit Summary

  • close reading of input files
  • more robust testing

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/YingyiLiu/HAMS/pull/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2G3NFPC27N4Y2QJWYJUULTOZZG3ANCNFSM45JKP4CQ .