search

YingyiLiu / HAMS

An open-source computer program for the analysis of wave diffraction and radiation of three-dimensional floating or submerged structures
Apache License 2.0
100 stars 50 forks source link

Final testing and makefile tweaks #14

Closed gbarter closed 3 years ago

gbarter commented 3 years ago

@YingyiLiu Yes, I also have to reorder the compilation of files to ensure all dependencies were satisfied.

I have moved to relative error on the checks and am closer matching to your compiler options, but the tests still fails. In other projects, comparing across platforms and compilers sometimes requires that the truth files and all checks be done with no architecture tunings and -O0 on optimization. We may be in that situation, but that will also require more coding logic on the tests and generating the truth files. Otherwise I am a little stuck. For now, I have commented out the regression tests from the GitHub actions, so it only tests for successful compilation.

YingyiLiu commented 3 years ago

@gbarter Thanks for your hard effort. But I am really sorry that I do not quite understand your commented issues. Therefore, I would like to ask that if I am able and what should I do to offer some help?