YingyiLiu / HAMS

An open-source computer program for the analysis of wave diffraction and radiation of three-dimensional floating or submerged structures
Apache License 2.0
100 stars 50 forks source link

Support zero and infinite frequency response #16

Closed gbarter closed 3 years ago

gbarter commented 3 years ago

Hi Yingyi,

Does HAMS support the 0-frequency and infinite-frequency response? Maybe the infinite frequency through some Wamit-style use of negative frequency input values?

Many thanks, Garrett

YingyiLiu commented 3 years ago

Dear Garrett,

Yes, HAMS can support the 0- and infinite-frequencies calculation (the part being commented out in the main program). I need to have some time to enable that. The functionality is not realized via infinite frequency input, but by modifying the Green function for the two special cases. I will let you know when this functionality is ready to use.

Best regards, Yingyi

Garrett Barter @.***> 于2021年7月1日周四 上午3:49写道:

Hi Yingyi,

Does HAMS support the 0-frequency and infinite-frequency response? Maybe the infinite frequency through some Wamit-style use of negative frequency input values?

Many thanks, Garrett

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/YingyiLiu/HAMS/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2G3NB4I6ZRVUWF2MFQT23TVNRNPANCNFSM47S5K3UQ .

gbarter commented 3 years ago

Thank you for the quick response. Let me know when you get around to making these changes. In the meantime, we will use a very large finite frequency to approximate the infinite frequency response.

gbarter commented 3 years ago

I see in the commented out section in HAMS_Prog running very small and negative frequency values. If it helps, HAMS does seem to run fine and give reasonable answers if given a frequency of 0.0.

YingyiLiu commented 3 years ago

Dear Garrett,

I have enabled the functionality for the two frequency limits in the latest updates. I removed the commented-out section and coded this part in a much simpler way.

Please note that for the time being, while the functionality works perfectly well for the infinite-depth condition, it should only be used as an approximation for the exact values (typically having a relative error of up to 20~30% in the added mass) in the finite-depth conditions (especially when the water depth is very shallow in comparison to the draught of the floating body), I will study the precise way of evaluating the limits in finite-depth conditions. I will let you know when this improvement is ready.

Best regards, Yingyi

Garrett Barter @.***> 于2021年7月1日周四 下午8:50写道:

I see in the commented out section in HAMS_Prog running very small https://github.com/YingyiLiu/HAMS/blob/master/SourceCode/HAMS_Prog.f90#L221 and negative https://github.com/YingyiLiu/HAMS/blob/master/SourceCode/HAMS_Prog.f90#L247 frequency values. If it helps, HAMS does seem to run fine and give reasonable answers if given a frequency of 0.0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/YingyiLiu/HAMS/issues/16#issuecomment-872178767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2G3NAL65NNM445US3EUN3TVRI7BANCNFSM47S5K3UQ .

gbarter commented 3 years ago

Things are working great- thank you!

Might want to update the documentation regarding the new line in the Control file, but this Issue has definitely been addressed.

YingyiLiu commented 3 years ago

Thanks, the documentation has been updated.

Garrett Barter @.***> 于2021年7月3日周六 上午1:14写道:

Things are working great- thank you!

Might want to update the documentation regarding the new line in the Control file, but this Issue has definitely been addressed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/YingyiLiu/HAMS/issues/16#issuecomment-873110412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2G3NERHBFDCI2X3KJZMRLTVXQXJANCNFSM47S5K3UQ .