search

Yinzo / sd-webui-Lora-queue-helper

A Script that help you generate a batch of Lora, using same prompt & settings. Helpful for compare Lora, Or just switching Lora easily without switch tab.
MIT License
27 stars 2 forks source link

base lora path of --lora-dir #1

Closed w-e-w closed 7 months ago

w-e-w commented 7 months ago

command line arg --lora-dir can change the lora-dir to something other then the default models/Lora

Changes

note: since the script has been installed on webui the default value models/Lora would have been save to ui-config.json > customscript/lora_queue.py/img2img/Base directory/value, if you remove the entry webui will recreate the entry ewith the new default ""

user can also update ui-config.json vai Setting > Defaults

Yinzo commented 7 months ago

Glad you told me about that --lora-dir argument and that's definitely better than hard-coded path. And about the ui-config.json stores the default value, I haven't considered that before. After reviewing your commit, I have a better solution in my opinion:

  1. Disable and hide the Base Directory textbox in default and use --lora-dir path only.
  2. add a new checkbox to enable and display the Base Directory textbox.

So that user can use lora-dir by default, and still be capable of changing lora directory on the fly.

I haven't used Github for a pretty long time. It has been painful to add commits to PR from others. So I am going to merge your PR, then make the change I have mentioned and push to this repo's main branch. If there is a better way to add commits to PR, please tell me.

Please tell me if I understood you incorrectly, and thanks for your help!