search

Yitching / pe

0 stars 0 forks source link

GameMenu Sequence Diagram #13

Open Yitching opened 3 years ago

Yitching commented 3 years ago

image.png

Perhaps self invocation method of showRecord() should have a new nested activation bar?

image.png

Perhaps activation bar should not end before return arrows?

soc-se-bot commented 3 years ago

Team's Response

Noted with thanks! sorry for the carelessness.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Missing activation bar

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

[original: nus-cs2113-AY2122S1/pe-interim#1294] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Noted with thanks!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is a different sequence diagram (Game menu sequence diagram) as compared to the one the team marked as a duplicate bug (Card menu sequence diagram). According to the module website, errors across multiple diagrams should not be flagged as duplicates.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I feel that this should be a medium documentation bug as I flagged two major errors in the same sequence diagram. Firstly, there is an activation bar missing for the self-invocation method which could hinder understanding. In addition, the activation bar ended before the return statement, which is wrong as well because in the first place you can't return anything from a non-existent object.