search

Yitching / pe

0 stars 0 forks source link

Exception thrown when using special character as name in continue #8

Open Yitching opened 3 years ago

Yitching commented 3 years ago

image.png

soc-pe-bot commented 3 years ago

Team's Response

Hi, thank you for your question. Even though I accepted this bug, but this is not a code issue. It's because the a filename cannot contain any of the following characters: \ / : * ? " < > |. If you try to rename a file by yourself, you will be able to find this problem. But there is a solution to check the input before searching the file, this is why I accepted.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I disagree that the severity should be low and feel that it should be at least a medium. While it may be the case that filename cannot contain any of the following characters: \ / : * ? " < > |, the prompt is asking for a userid and there was no warning that userid cannot be just a special character/contain special characters. In addition, if this was the case, perhaps it would have been better to restrict the input rather than assume that the user would know that it is not allowed. Alternatively, perhaps the exception should have been caught if this issue was already known.