search

Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
4k stars 540 forks source link

Files tab - viewing a folder with a lot of files crashed the agent #3041

Closed soapster closed 2 years ago

soapster commented 3 years ago

I opened a folder that contained over 28k files, and it crashed the agent.

We have alternative ways to do what I was going to do, so we aren't stuck... I just wanted to mention it.

The agent did restart after the crash.

Ylianst commented 3 years ago

Oh dear. Thanks for reporting that. I don't think I would have ever tested that case. I wonder if it's related to #3004 as the agent seems to have problems sending large data blocks.

soapster commented 3 years ago

I don't think so, but maybe. We have stations here with 4 monitors, and so far have not crashed. I'll get it installed on a station with 2x 5k monitors to see how it behaves.

krayon007 commented 3 years ago

Which agent was this, windows or Linux?

PathfinderNetworks commented 3 years ago

I have seen this same issue as well. In my case it is the Windows agent.

soapster commented 3 years ago

Yes, windows agent, on windows 10 2009

soapster commented 3 years ago

So, I was able to test it on Windows 10 with 4 monitors, 2 of which were 4k resolution, and it did not have any issues. The 4K are actually 1 monitor, with 2 displays... EIZO RX850. 8k monitor, but it's basically 2x 4K with no bezel. Windows sees it as 2 monitors.

Ylianst commented 3 years ago

So, it's not the number of monitors that will cause the issue. Rather, you need to cause the agent to send a single very large command. Sent the quality to 90% in desktop settings and put a complex image on the screen and hit connect. That should generate a very large and complex JPEG that, if sufficient large, will (hopefully) crash the agent. Bryan is looking into it.

soapster commented 3 years ago

Well, this issue is in regards to the number of files in a folder. I was only commenting on the monitors because you referenced another issue.

Ylianst commented 3 years ago

Understood. My theory is that both issues are related. The agent will crash if sending a single very large command. You can make that happen with lots of files or a complex remote desktop. Bryan is looking into it.

Ylianst commented 3 years ago

Bryan did a fix for this. MeshCentral v0.9.16 was published with new MeshAgents that should fix this issue for all OS's. Let us know if it works.