Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
4.07k stars 546 forks source link

ZIP function stuck when in use files #4131

Open energywave opened 2 years ago

energywave commented 2 years ago

Describe the bug I zipped some files and some folders in the "Files" section of a remote Windows agent. It was stuck in the progress dialog. Refreshing files there was a 0 bytes zip file that could not be deleted. Trying to zip something other it's stuck in the progress dialog without any text. Same behavior: 0 bytes zip, not deletable. I discovered that some of the files where in use by another process.

To Reproduce

  1. Go to files
  2. Select some files and some folders
  3. Open one of the files in a subfolder with some software that locks the file
  4. Press zip
  5. It will hang mid process

Expected behavior ZIP should, well, zip selected files and folders, maybe excluding in use files with a notice.

Screenshots image

Server Software (please complete the following information):

Remote Device (please complete the following information):

Additional context

krayon007 commented 2 years ago

Thanks, I'll take a look at this

Otsegox commented 2 years ago

I can confirm I have seen this behavior. I just never reported it.

silversword411 commented 2 years ago

...are you trying to zip something in use/no permissions? I've seen that trying to grab stuff I can't grab

Otsegox commented 2 years ago

Not in the cases I've seen. Usually a larger number of files that are in total fairly large. For instance, 300+ files that are 100-300kb each.

energywave commented 2 years ago

In my case I had 4 folders with no subfolders. One small INI file in the root. 1 to 3 small files (<1KB) in each folder except the logs folder that contained files shown in this screenshot from the server image The software that generated those logs was running (but it writes on the current log and immediatly close it so files are normally moveable. This let me doubt that in use file was the real problem...) I can do some tests, if you ask.

ITCMD commented 8 months ago

Also having this bug