search

Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
4k stars 540 forks source link

Computer's model on Details #4432

Closed dxdemetriou closed 8 months ago

dxdemetriou commented 2 years ago

Describe the bug If it's possible to be added the Computer Model in the Details (ex. HP ProBook 450 G2)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'My Devices'
  2. Select any computer
  3. Go to 'Details' tab
  4. See error: Computer's model is not shown

Expected behavior To be able to see the computer's model (ex. HP ProBook 450 G2)

dxdemetriou commented 2 years ago

Some info here of how it's handled by GLPI-Agent:

https://github.com/glpi-project/glpi-agent/blob/develop/lib/GLPI/Agent/Task/Inventory/Win32/Bios.pm

si458 commented 2 years ago

this is a feature request rather than a bug all our dell pcs and hp servers, dont show a computer model, but we do have a Toshiba Laptop which shows Vendor and Name under motherboard which is actually the laptops make and model

dxdemetriou commented 2 years ago

Yes, that's what I have seen on GLPI-Agent that chooses each purpose of how to get the information, that's showing in the BIOS.pm on each OS. For example on Windows it takes the components using getWMIObjects, and chanes the variables accordingly.

Can the Tag be changed to Feature Request as I cannot see an option?

si458 commented 11 months ago

@dxdemetriou please can you run the following outputs on ur machines in powershell and let me have a few random ones? im interested in the outputs so i can add the extra stuff into the details tab

Get-WmiObject -Class Win32_Baseboard

Manufacturer : Dell Inc.
Model        : 
Name         : Base Board
SerialNumber : /2CGH55J/CN7360417T07N6/    
SKU          : 
Product      : 0D28YY

Manufacturer : ASUSTeK COMPUTER INC.
Model        :
Name         : Base Board
SerialNumber : MB46NBCX00SW6SMB
SKU          :
Product      : M3500QC

Manufacturer : Hewlett-Packard
Model        : 
Name         : Base Board     
SerialNumber : CZC1024936     
SKU          : 
Product      : 3646h
Get-WmiObject -Class Win32_Bios   

SMBIOSBIOSVersion : A22
Manufacturer      : Dell Inc.
Name              : A22
SerialNumber      : 2CGH55J
Version           : DELL   - 6222004       

SMBIOSBIOSVersion : M3500QC.316
Manufacturer      : American Megatrends International, LLC.
Name              : M3500QC.316
SerialNumber      : MCN0CX01K82148D
Version           : _ASUS_ - 1072009

SMBIOSBIOSVersion : 786G7 v01.06
Manufacturer      : Hewlett-Packard        
Name              : Default System BIOS    
SerialNumber      : CZC1024936
Version           : HPQOEM - 20100617
Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : 2CGH55J
Name              : OptiPlex 790
Vendor            : Dell Inc.
Version           : 01
Caption           : Computer System Product

IdentifyingNumber : MCN0CX01K82148D
Name              : Vivobook_ASUSLaptop M3500QC_M3500QC
Vendor            : ASUSTeK COMPUTER INC.
Version           : 1.0
Caption           : Computer System Product

IdentifyingNumber : CZC1024936
Name              : HP Compaq 8000 Elite SFF PC
Vendor            : Hewlett-Packard
Version           :  
Caption           : Computer System Product
dxdemetriou commented 11 months ago

@si458

Get-WmiObject -Class Win32_Baseboard

Manufacturer : Dell Inc.
Model        :
Name         : Base Board
SerialNumber : /GZRxxxx/CNxxxxxxxxxxxx/
SKU          :
Product      : 0HY9JP

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : A22
Manufacturer      : Dell Inc.
Name              : Default System BIOS
SerialNumber      : GZRxxxx
Version           : DELL   - 6222004

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : GZRxxxx
Name              : OptiPlex 790
Vendor            : Dell Inc.
Version           : 01
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : HP
Model        :
Name         : Base Board
SerialNumber : PGTXLxxxxxxxxx
SKU          :
Product      : 83E1

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : Q01 Ver. 02.04.01
Manufacturer      : HP
Name              : Default System BIOS
SerialNumber      : CZCxxxxxxx
Version           : HPQOEM - 0

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : CZCxxxxxxx
Name              : HP EliteDesk 800 G4 SFF
Vendor            : HP
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : Hewlett-Packard
Model        :
Name         : Base Board
SerialNumber : CZCxxxxxxx
SKU          :
Product      : 18E7

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : L01 v02.33
Manufacturer      : Hewlett-Packard
Name              : Default System BIOS
SerialNumber      : CZCxxxxxxx
Version           : HPQOEM - 20140715

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : CZCxxxxxxx
Name              : HP ProDesk 600 G1 TWR
Vendor            : Hewlett-Packard
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : HP
Model        :
Name         : Base Board
SerialNumber : PKPSLxxxxxxxxx
SKU          :
Product      : 8846

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : T76 Ver. 01.14.00
Manufacturer      : HP
Name              : T76 Ver. 01.14.00
SerialNumber      : 5CGxxxxxxx
Version           : HPQOEM - 0

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : 5CGxxxxxxx
Name              : HP EliteBook 850 G8 Notebook PC
Vendor            : HP
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : HP
Model        :
Name         : Base Board
SerialNumber : PHUQCxxxxxxxxx
SKU          :
Product      : 8592

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : R01 Ver. 02.05.01
Manufacturer      : HP
Name              : Default System BIOS
SerialNumber      : CZCxxxxxxx
Version           : HPQOEM - 0

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : CZCxxxxxxx
Name              : HP EliteDesk 800 G5 SFF
Vendor            : HP
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : FOXCONN
Model        :
Name         : Base Board
SerialNumber :
SKU          :
Product      : 2A8Ch

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : 5.09
Manufacturer      : American Megatrends Inc.
Name              : BIOS Date: 11/27/09 14:17:53 Ver: 5.09
SerialNumber      : CZCxxxxxxx
Version           : HPQOEM - 20091127

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : CZCxxxxxxx
Name              : Compaq 500B Microtower
Vendor            : Hewlett-Packard
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : FOXCONN
Model        :
Name         : Base Board
SerialNumber :
SKU          :
Product      : 2A8C

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : 6.01
Manufacturer      : American Megatrends Inc.
Name              : BIOS Date: 04/01/10 08:35:28 Ver: 6.01
SerialNumber      :
Version           : HPQOEM - 20100401

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber :
Name              :
Vendor            : Hewlett-Packard
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : HP
Model        :
Name         : Base Board
SerialNumber : PBLVDxxxxxxxxx
SKU          :
Product      : 8079

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : N75 Ver. 01.09
Manufacturer      : HP
Name              : Default System BIOS
SerialNumber      : 5CGxxxxxxx
Version           : HPQOEM - 0

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : 5CGxxxxxxx
Name              : HP EliteBook 840 G3
Vendor            : HP
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : HP
Model        :
Name         : Base Board
SerialNumber : PGDUCxxxxxxxxx
SKU          :
Product      : 828C

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : P78 Ver. 01.39
Manufacturer      : HP
Name              : Default System BIOS
SerialNumber      : 5CGxxxxxxx
Version           : HPQOEM - 0

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : 5CGxxxxxxx
Name              : HP EliteBook 840 G4
Vendor            : HP
Version           :
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : Hewlett-Packard
Model        :
Name         : Base Board
SerialNumber : PELSAxxxxxxxxx
SKU          :
Product      : 2248

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : M74 Ver. 01.47
Manufacturer      : Hewlett-Packard
Name              : Default System BIOS
SerialNumber      : CNDxxxxxxx
Version           : HPQOEM - 1

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : CNDxxxxxxx
Name              : HP ProBook 450 G2
Vendor            : Hewlett-Packard
Version           : A3009DD10303
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : LENOVO
Model        :
Name         : Base Board
SerialNumber : 1ZKCxxxxxxx
SKU          :
Product      : 42363E1

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : 83ET74WW (1.44 )
Manufacturer      : LENOVO
Name              : Default System BIOS
SerialNumber      : 4236xxxxxxx
Version           : LENOVO - 1440

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : 4236xxxxxxx
Name              : 42363E1
Vendor            : LENOVO
Version           : ThinkPad T420
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : Dell Inc.
Model        :
Name         : Base Board
SerialNumber : .C6Dxxxx.CN701xxxxxxxxx.
SKU          :
Product      : 01HXXJ

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : A03
Manufacturer      : Dell Inc.
Name              : BIOS Date: 10/14/11 14:44:39 Ver: 04.06.04
SerialNumber      : C6Dxxxx
Version           : DELL   - 1072009

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : C6Dxxxx
Name              : Inspiron N5050
Vendor            : Dell Inc.
Version           : Not Specified
Caption           : Computer System Product
Get-WmiObject -Class Win32_Baseboard

Manufacturer : ASUSTeK COMPUTER INC.
Model        :
Name         : Base Board
SerialNumber : MT70xxxxxxxxxxx
SKU          :
Product      : P8Z77-V LE

Get-WmiObject -Class Win32_Bios

SMBIOSBIOSVersion : 0513
Manufacturer      : American Megatrends Inc.
Name              : BIOS Date: 05/22/12 11:10:07 Ver: 05.13
SerialNumber      : System Serial Number
Version           : ALASKA - 1072009

Get-WmiObject -Class Win32_ComputerSystemProduct

IdentifyingNumber : System Serial Number
Name              : System Product Name
Vendor            : System manufacturer
Version           : System Version
Caption           : Computer System Product
si458 commented 11 months ago

@dxdemetriou thank you! my suspensions where correct, so i need to query Win32_ComputerSystemProduct and use Name to get the model ! only expection seems to be LENOVO why they put it in Version i have no idea? maybe firmware bug for that device? and ASUS motherboards as they use Product in BaseBoard instead which seems correct as its a motherboard

P.S: you can view BIOS SERIAL and MODE in 1.1.12 now hehe

si458 commented 8 months ago

recent PR was added to fix this for you, will be in next update 👍