Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
4.08k stars 549 forks source link

Meshcntrl.js filter device by name that is number broken #6091

Closed kpetrow closed 4 months ago

kpetrow commented 4 months ago

NODE meshctrl.js ListDevices [..private stuff...] --json --group xxxxx --filter "1490"

throws data.nodes[meshid] = parseSearchOrInput(data.nodes[meshid], args.filter.toLowerCase());

resolved by adding to line 2244: data.nodes[meshid] = parseSearchOrInput(data.nodes[meshid], args.filter.toString().toLowerCase());

tag and atag do not seem to have to the tolowercase issue

ERROR:

simon@testmc:~/meshcentral/MeshCentral$ node meshctrl.js ListDevices --loginuser admin --loginpass pass --json --group myothergroup --filter "111"
/home/simon/meshcentral/MeshCentral/meshctrl.js:2245
                                data.nodes[meshid] = parseSearchOrInput(data.nodes[meshid], args.filter.toLowerCase());
                                                                                                        ^

TypeError: args.filter.toLowerCase is not a function
    at WebSocket.incoming (/home/simon/meshcentral/MeshCentral/meshctrl.js:2245:105)
    at WebSocket.emit (node:events:517:28)
    at Receiver.receiverOnMessage (/home/simon/meshcentral/MeshCentral/node_modules/ws/lib/websocket.js:1192:20)
    at Receiver.emit (node:events:517:28)
    at Receiver.dataMessage (/home/simon/meshcentral/MeshCentral/node_modules/ws/lib/receiver.js:560:14)
    at Receiver.getData (/home/simon/meshcentral/MeshCentral/node_modules/ws/lib/receiver.js:478:17)
    at Receiver.startLoop (/home/simon/meshcentral/MeshCentral/node_modules/ws/lib/receiver.js:167:22)
    at /home/simon/meshcentral/MeshCentral/node_modules/ws/lib/receiver.js:180:18
    at node:internal/process/task_queues:140:7
    at AsyncResource.runInAsyncScope (node:async_hooks:203:9)

Node.js v18.19.0
si458 commented 4 months ago

yep can confirm! pushed your fixed thank you! https://github.com/Ylianst/MeshCentral/commit/77d268d064c1a450a3038bd12397b1e25e993dd6