Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
3.68k stars 511 forks source link

Keyboard input not working after sending Ctrl+Alt+Delete in shared link remote session #6120

Closed JasperE84 closed 1 month ago

JasperE84 commented 1 month ago

Describe the bug Cannot use keyboard text input after clicking the CtrlAltDelete [Send] button in a shared link session. This only appears to be an issue with shared link sessions. (In this case a desktop+terminal+files share session with expiry set to 48hrs)

To Reproduce Steps to reproduce the behavior:

  1. Go to meshcentral remote session using a shared link
  2. Click on the "Send" button next to "Ctrl+Alt+Delete" dropdown control
  3. Click any text-input object in the remote session
  4. Type something and it won't work
  5. Disconnect/Reconnect to remote session using the button top left
  6. Text input works again

Expected behavior Able to type using keyboard input after CtrlAltDelete

Server Software (please complete the following information):

Client Device (please complete the following information):

Remote Device (please complete the following information):

Your config.json file

{
  "$schema": "https://raw.githubusercontent.com/Ylianst/MeshCentral/master/meshcentral-config-schema.json",
  "settings": {
    "plugins":{"enabled": false},
    "mongoDb": "mongodb://mongodbadmin:REDACT@mongodb:27017",
    "cert": "REDACT.mycomp",
    "_WANonly": true,
    "_LANonly": true,
    "sessionKey": "REDACT",
    "port": 4430,
    "aliasPort": 443,
    "agentAliasPort": 4021,
    "agentAliasDNS": "REDACT-agent.mycomp.eu",
    "redirPort": 800,
    "_redirAliasPort": 80,
    "AgentPong": 300,
    "TLSOffload": true,
    "SelfUpdate": false,
    "AllowFraming": false,
    "WebRTC": false
  },
  "domains": {
    "": {
      "title": "MySupport",
      "title2": "docker",
      "minify": true,
      "NewAccounts": false,
      "localSessionRecording": false,
      "_userNameIsEmail": true,
      "certUrl": "https://REDACT.mycomp:443",
      "SessionRecording": {
        "onlySelectedDeviceGroups": false,
        "filepath": "/opt/meshcentral/meshcentral-data/session_recordings",
        "index": true,
        "maxRecordingSizeMegabytes": 2048,
        "protocols": [1,2]
      }
    }
  },
  "_letsencrypt": {
    "__comment__": "Requires NodeJS 8.x or better, Go to https://letsdebug.net/ first before>",
    "_email": "myemail@mydomain.com",
    "_names": "myserver.mydomain.com",
    "production": false
  }
}
si458 commented 1 month ago

huh thats weird just replicated it here and its only the sharing page that has this bug? if you use the normal tab/user it works no problem?

also weirdly enough you can use the arrow keys just no characters? will look into it

JasperE84 commented 1 month ago

Yeah I believe it did work on the normal logged in user. (I noticed it because I was testing a shared link which I use for a software vendor. They had some problems logging in to our system using the shared link. Which I found weird because I hadn't experienced this issue on my day to day usage for endpoint management)

si458 commented 1 month ago

all done and fixed! its 1 line command that was missing! if you want to patch urself 👍 https://github.com/Ylianst/MeshCentral/commit/abbb0fa9ee8f5b094e02333070b8266d9e7158c3

p.s: also fixed the timer/latency too as that was bugging me haha https://github.com/Ylianst/MeshCentral/commit/89b67ff999543399e3a05d0adada63663900d7f3

JasperE84 commented 1 month ago

Thanks! Thats excellent! Ill see if ican find my way around the docker containers to patch this until its in the docker package release :)

si458 commented 1 month ago

For docker just use master instead of v1.1.23 or latest

P.s every time we push a commit to the master branch it auto builds a master image hehe