Battery Percentage no longer showing on many Laptop Types (since 1.1.23)

[NilsLeumann]

Describe the bug Since version 1.1.23 and also on version 1.1.24 many laptops that used to show the battery state of charge now no longer show it (no battery Icon, just like the computer doesn't have a battery) Tested Laptops: Surface Pro 6 (only one affected), ThinkPads (but only a P16, all my E14 AMD show battery just fine), HP ProBooks (only Intel models, so far no AMD) In my testing it mainly seemed to affect intel based laptops, however I have not yet been able to determine a clear pattern

To Reproduce Steps to reproduce the behavior: Well, just log on to meshcentral and check if there is a battery icon :)

Screenshots If applicable, add screenshots to help explain your problem.

Server Software (please complete the following information):

• OS: Ubuntu
• Virtualization: Proxmox
• Network: WAN
• Version: 1.1.24

Client Device (please complete the following information):

• Device: Laptop (MBP 14" 2021)
• OS: Mac
• Network: Lan
• Browser: Chrome (latest)

Remote Device (please complete the following information):

• Device: Laptop (Lenovo, HP, Surface, seemingly at random, I have multiple Surfaces (exact same specs) and only one seems to not show batttery percentage
• OS: Windows 10 (22H2) and Windows 11 (23H2)
• Network: WAN
• Current Core Version: December 2022

[si458]

yeh ive spotted this recently too and i cant work it out whats happened? i moved the power-monitor.js from meshagent to meshcentral so it fixed the battery tracking for mac laptops https://github.com/Ylianst/MeshCentral/commit/b71b4d04e67175492f608c3b69eb5b2ce2b22804 but it seems to of possibly broke the windows battery?

can you try one thing for me, delete agents/modules_meshcore/power-monitor.js then restart ur meshcentral server?

does the battery levels etc return?

[si458]

yes deleting node_modules/meshcentral/agents/modules_meshcore/power-monitor.js and restarting meshcentral restored the battery levels for laptops, it just loses the battery levels for mac again so i will do more investigating again

[NilsLeumann]

Thank you very much for your quick reply, since I do not manage any Macs in MeshCentral I deleted the power-monitor.js or rather renamed it and added a .old Now it seems to work fine, at least on one of my HP Laptops that didn't show the battery percentage before. I assume all other devices will be fine now but I will see on monday I also just want to thank you for making and maintaining such an amazing piece of open source software :))

[si458]

@NilsLeumann glad it temporarily sorted the issue. im gunna look into it fully tho as i am confused? as you said it seemt to show on some but then not others and i dont know how i didnt spot it! glad u like the software! dont forget to donate ❤️ https://www.si458.co.uk/2024/01/05/donation/

[si458]

closing this as i have removed the file from the master image and npm install Ylianst/MeshCentral