search

Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
3.67k stars 511 forks source link

Star is in my Devices List view in front of the Device Description #6174

Closed tobias9931 closed 3 weeks ago

tobias9931 commented 3 weeks ago

Describe the bug The star is in the “My device” view when you switch to the list directly on the text of the device description. You cannot read the device description in this manner.

To Reproduce Steps to reproduce the behavior:

  1. Mark a device as a favorite. (Toggle Star)
  2. Go to my devices
  3. Filter to starred
  4. Switch the view to list
  5. Enable under Device View Columns "Device Description"

Expected behavior The star should not cover the text of the device description

Screenshots

tobias9931 commented 3 weeks ago

Github doesn't let me upload a screenshot?! :(

si458 commented 3 weeks ago

like this i got you image

EDIT: it happens without filtering too, we just need to add a bit of padding 👍 image

si458 commented 3 weeks ago

better? image

tobias9931 commented 3 weeks ago

better? image

Oh yes much better! Thanks for that very quick answer

tobias9931 commented 3 weeks ago

@si458 how can we get this fix on our Server? We have installed MeshCentral on a Windows VM, current with Version 1.1.22. Can we search for updates an just you know install version 1.1.23?

Or how is this regulated here?

si458 commented 3 weeks ago

You have to wait for a new release.

Or

The fix is actually a single line.

So edit the default.handlebars and paste in the patch https://github.com/Ylianst/MeshCentral/commit/c053c14dd0a08cf625a1211f1f346645e54b8e3f

tobias9931 commented 3 weeks ago

All right, then I'll change the one line manually myself.

@si458 One more general question: Who took care of the new release? When and at what frequency do new releases for MeshCentral will be released? Is it then guaranteed that this one change is present in V. 1.1.23?

si458 commented 3 weeks ago

the latest version is actually 1.1.24 so u are 2 versions behind but this fix will be be included in the next release (1.1.25)

I try to ask @Ylianst to do releases once a month as its his NPM package so he has control over it.

also if you have docker you can use the master image to get new features/bug fixes instantly (its build every time we push a commit) ghcr.io/ylianst/meshcentral:master

also if you are happy you can do an npm install Ylianst/MeshCentral which will download the github master repo rather than from NPM but it has all the new features/bug fixes just sadly missing all the translations

but remember the master/github repo might have bugs so dont use in production unless you are 110% happy

tobias9931 commented 3 weeks ago

All right, thank you very much, we will now do the normal update from 1.2.22 to 1.2.24 and then I will change the one line manually as you described. This manual change should then not be lost during the normal update to 1.2.25.

Thanks for the quick change and the quick answers, I think you are really doing a great job here. @si458 @Ylianst