search

Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
3.67k stars 511 forks source link

Changing filter category menu refills the value in the filter field #6206

Closed vgz closed 1 week ago

vgz commented 1 week ago

Describe the bug If you clear the filter field and change the category (offline, online, all, etc), the filter field is reset to the last text entry. This is occurring on Safari 17.5 on macOS 14.5 and the latest version of Chrome on Win 10.

To Reproduce

  1. Type something into the filter field.
  2. Clear the filter field.
  3. Change the category.

The filter field will now have the text that was cleared in step 2.

Expected behavior Changing the category should not have any effect on the content of the filter field.

Server Software (please complete the following information):

bytegun commented 1 week ago

Hi, @Ylianst I would love to contribute to this open source project. Cheers!

si458 commented 1 week ago

OOOO yes i see the same, Safari and Chrome ! will look into it soon

si458 commented 1 week ago

all fixed in PR! you can test by copying the changes in the PR to default.handlebars and remember to set minify: false and use english translation!

edit: also fixed a bug where if u clear the text box in filter, it was also clearing the state filter box next to it?

vgz commented 1 week ago

Thanks for the prompt response. I copied your changes into our server's default.handlebars and can confirm it fixes the issue. Should I close this issue since you have the open PR to track the issue with the proper fix or leave it open until the PR is merged?

si458 commented 1 week ago

all done, closed for you 👍 just wanted confirmation that the fix worked before i merged+closed issue! dont forget to donate ❤️ https://www.si458.co.uk/2024/01/05/donation/