search

Ylianst / MeshCentral

A complete web-based remote monitoring and management web site. Once setup you can install agents and perform remote desktop session to devices on the local network or over the Internet.
https://meshcentral.com
Apache License 2.0
4.3k stars 574 forks source link

Pressing Enter on the login screen no longer works in 1.1.33 #6514

Closed Br0kenSilos closed 2 weeks ago

Br0kenSilos commented 2 weeks ago

Describe the bug First, THANK YOU for all of the great work you have been doing. I am really happy to see development on MC taking place and I am excited for it's future again.

Normally (on all previous versions), when at the main login screen, I have been able login by auto-fill (from Bitwarden) the login and password and then simply hitting Enter. However, since updating to 1.1.33, this function no longer works and I must mouse over and click the Login button. Then it will proceed to the next screen where I can use my security key for 2FA. Easy to work around. This is just more of an annoyance than anything else.

To Reproduce Steps to reproduce the behavior:

  1. Go to to the main login screen
  2. Fill in your credentials.
  3. Press the "Enter" button (Do not hit the tab button first to select login)
  4. Nothing happens.

Expected behavior Pressing Enter should (and has in the past) worked to initiate the login process.

Screenshots Nothing to show really

Server Software (please complete the following information):

Client Device (please complete the following information):

Remote Device (please complete the following information):

Additional context I have also tested this without the use of auto-fill and typed in credentials. No difference. I have a friend who has also noticed this behavior on his server as well.

si458 commented 2 weeks ago

Duplicate #6494 Already fixed :)

Commit here to fix it :)

We removed it to fix edge password filling,

then realised how many people use the enter method. So restored it :)

https://github.com/Ylianst/MeshCentral/commit/9ebd23a5182cc5a63b359ccb57eac0f9b49d4934

Br0kenSilos commented 2 weeks ago

Ope, sorry. I didn't see the previous issue. Thank you Simon. :-)