YlmRdm / dropkick-syntax

syntax theme for atom editor
MIT License
1 stars 1 forks source link

Deprecated selector in `dropkick-dark-syntax/index.less` #2

Open Yirvan opened 6 years ago

Yirvan commented 6 years ago

In dropkick-dark-syntax/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

YlmRdm commented 5 years ago

I got same issues for 1.36.0 x64

frodo4fingers commented 5 years ago

sorry for my late answer... i am no longer using atom as editor and am therefore not able to reproduce the steps. if there is a volunteer i would be glad to hand over this repo

YlmRdm commented 5 years ago

sorry for my late answer... i am no longer using atom as editor and am therefore not able to reproduce the steps. if there is a volunteer i would be glad to hand over this repo

I can handle, if you want...

frodo4fingers commented 5 years ago

i want, i did. did you get the request?

YlmRdm commented 5 years ago

i want, i did. did you get the request?

Nope, I couldn't see any request from you…

frodo4fingers commented 5 years ago

wellll... i never did this before but it looks right. i aborted the whole thing and retried.. still nothing? no mail or similar? 2019-07-05-094618_3200x1080_scrot

(sorry for the spam navri)

YlmRdm commented 5 years ago

Now, It looks normal, right? Can you see this repo in your profile?

frodo4fingers commented 5 years ago

yes. it worked. now its your's :-)

YlmRdm commented 5 years ago

yes. it worked. now its your's :-)

Thanks a lot ;)