search

Ymagis / ClairMeta

Clairmeta is a python package for Digital Cinema Package (DCP) probing and checking.
BSD 3-Clause "New" or "Revised" License
84 stars 22 forks source link

Empty element text content check in Assetmap #183

Closed matmat closed 3 years ago

matmat commented 3 years ago

https://github.com/Ymagis/ClairMeta/blob/376a5e2e6f71637d984a501a0fe01ec0ec2aba43/clairmeta/dcp_check_am.py#L61-L66

Why do we check for empty element text content here?

I think it should be allowed with empty element text content. The only constraint I can find is that some of these elements must be present, but there is no constraints on their text contents.

Issuer and Creator elements are mandatory both for Interop and SMPTE. AnnotationText (top level) element are optional. This is already checked for with the XML schemas.

Both standard documents contains the following text:

The AnnotationText element is a free-form, human-readable annotation (...) it is meant strictly as a display hint to the user.

References

remia commented 3 years ago

Agreed that this check is not backed by standard and it is indeed listed as warning in the default check profile.

If memory serve, it was added to match another commercial check tool, maybe EasyDCP. It maybe good to check that if someone has access to that tool, if so we should add a description here.

If we don't find reason we could delete it entirely of lower it's error level further more to info or silent ?

matmat commented 3 years ago

I think lowering to INFO would be a good solution.

remia commented 3 years ago

Pushed this to #192