Yo1k / tic-tac-toe

A multiplayer turn-based game
MIT License
0 stars 0 forks source link

Add Python files with game core logic and tests for it #9

Closed Yo1k closed 2 years ago

stIncMale commented 2 years ago

Are you sure that if you delete any of the new __init__.py files, then the tests will become not discoverable? I am especially suspicious about yo1k/tic_tac_toe/__init__.py and yo1k/tic_tac_toe/core/__init__.py.

Yo1k commented 2 years ago

Are you sure that if you delete any of the new __init__.py files, then the tests will become not discoverable? I am especially suspicious about yo1k/tic_tac_toe/__init__.py and yo1k/tic_tac_toe/core/__init__.py.

If yo1k/tic_tac_toe/__init__.py is deleted, tests will become not discoverable. It is worth noting that this need for __init__.py to discover tests is an old bug that hasn't been fixed yet.
The file yo1k/tic_tac_toe/core/__init__.py is needed for yo1k/tic_tac_toe/core to be a regular Python package and not related to tests.

Yo1k commented 2 years ago

FYI: Here is the convention for how to make docstrings for a function.