search

YoRyan / open-nec

A free and open-source Train Simulator Classic mod for Northeast Corridor locomotives.
https://opennec.trinancrat.me
GNU General Public License v3.0
7 stars 1 forks source link

Issue with NJT ADU on Comet V & Multilevel #2

Closed TovPrap closed 10 months ago

TovPrap commented 2 years ago

I have noticed on the NJT style ADU in the cab cars of the Comet V and Multilevel, the green arc does not show the track speed limit, but functions as the speed needle of a gauge. The alarms turn on and whatnot, but you don't exactly know what speed limit you have with the current set up of the ADU.

YoRyan commented 2 years ago

Hey, first GitHub issue! Thanks so much for the report.

Unfortunately, the green speed bar is not always under the control of Lua. Sometimes, DTG hardcoded the bar to act as a speedometer, irregardless of whatever control values the engine script sets. This is true for the models you've mentioned and also, I believe, the Arrow III.

It's likely possible to fix this by modifying the engine blueprints, but I'm always hesitant to make such a change, because other mods (Fan Railer, enhancement packs, etc.) often modify those kinds of files. So I've decided we can just live with this quirk on certain trains—but it would certainly not be a bad idea to make a note of it in the documentation.

TovPrap commented 2 years ago

This is a great project, and I love giving feedback, to help improve it!

I recall the Arrow III functions as intended.

It would be good to add in the notes section for these cab cars, that they have this issue with the ADU. At first I thought I had not installed it correctly.

YoRyan commented 10 months ago

Fixing for v2 by using the red speed bar to show the target speed—just for the ALP-45 version of the cab car, which is the only one this bug affects. Cheers!