YoYoCiti / pe

0 stars 0 forks source link

Participants with near impossible birth dates allowed to be added #2

Open YoYoCiti opened 2 years ago

YoYoCiti commented 2 years ago

Description Participants with impossible birth dates are allowed to be added with no warning or error. Such entries are likely to be accidental and incorrect, and users should be informed of errant entries like these that would affect the accuracy of their data.

Steps to Reproduce

  1. Enter command add n/ABC p/999 e/abc@abc.com a/Blk 999 Police Station d/1800-06-22

Expected Outcome User should be warned that birthdate is unlikely to be accurate.

Actual Outcome Participant born in year 1800 reflected in the list of participants.

image.png

nus-pe-bot commented 2 years ago

Team's Response

We can't rule out this possibility. To be fair, we can't fix a exact cut off birthdate for the oldest possible participant.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I still believe that there is lack of proper handling for such potential invalid inputs and should still be considered a feature flaw. It is not too complicated to check for errant cases in date of birth, and at least a warning should be provided for errant entries. As explained in the original bug report, such entries are likely to be accidental and incorrect, and the product's target users - event managers, would be affected by such blatant inaccuracies in the participants' details.