search

YoYoCiti / pe

0 stars 0 forks source link

Invalid Time Format Error Message should be more specific #5

Open YoYoCiti opened 2 years ago

YoYoCiti commented 2 years ago

Description: The user guide specifies that time should be inputted as 0000 - 2359 inclusive. However, the application displays time in the format of 00:00 - 23:59. This inconsistency may cause minor inconveniences with the user as they are likely to enter time parameters in the latter format instead, since that is what is presented in the application. When they do so, the error message is not specific enough to pinpoint such a mistake, which I believe would be quite common due to the above reasonings.

User Guide image.png

Application's Presentation

image.png

Steps to Reproduce

  1. Enter command filterEvents d/2021-11-20 t/09:00

Expected Outcome Filter events on 2021-11-20 at 9am

Actual Outcome Presented with an error message saying that time should be in 24hour format, between 0000-2359 inclusive, which at a glance does comply with the given input. A more specific error message can be provided so that user would know that the missing ':' is the issue.

image.png

nus-pe-bot commented 2 years ago

Team's Response

The instruction, example given in the user guide and the error message should be clear enough for normal users to understand. Moreover, missing : should be the correct format.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that the user guide has stated that the input format should be HHmm. However, I still feel that the inconsistency between the display format in the application HH:mm and the command format HHmm makes usage unnecessarily confusing, especially since standardizing the format is fairly simple to implement. As stated in the original bug report, with such inconsistencies in the format, the error message provided should then be more specific.