search

YoYoCiti / pe

0 stars 0 forks source link

Mismatch between UI class diagram and description #7

Open YoYoCiti opened 2 years ago

YoYoCiti commented 2 years ago

Description: The class diagram of UI omits EventCard and EventListPanel inheriting from UiPart. At the same time, the description following the diagram states that all the classes inherit from UiPart.

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

There is "etc" at the end of the sentence.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team responded that there is an "etc" at the end of the sentence, but this does not really mean anything to the issue that I have raised. I assume that the team misunderstood that the issue was not including EventCard and EventListPanel into the description. However, this is not the case.

As stated in the original bug report, the issue is the inaccuracy of the class diagram of Ui, in which that EventCard and EventListPanel should inherit UiPart (which is stated in the description provided as well as the codebase itself), however, the class diagram does not show this fact (No dashed arrow connecting EventCard and EventListPanel to UiPart. Furthermore, the omission is jarring since this inheritance is included for all the other relevant classes.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]