search

YoYoGames / GM-TestFramework

Repository for GameMaker's Test Framework
Other
21 stars 11 forks source link

Fixes #117 - Moved BasicVariableTestSuite to run after ResourceTimeSourceTestSuite & added timeout #118

Closed Indibulous closed 3 months ago

Indibulous commented 3 months ago

Moved BasicVariableTestSuite to run after ResourceTimeSourceTestSuite in objRunner.

Also added a 3000 millisecond timeout to "Time Sources: Expiry Frames" in ResourceTimeSourceTestSuite.

DiasFranciscoA commented 3 months ago

Moved BasicVariableTestSuite to run after ResourceTimeSourceTestSuite in objRunner.

Why was this moved? Was there a problem with it?

Indibulous commented 3 months ago

@DiasFranciscoA as described in #117 , still unsure of the exact cause, but the TestAsync "Time Sources: Expiry Frames" in ResourceTimeSourceTestSuite seems to have errors that only occur when run after BasicVariableTestSuite. This causes the framework to get stuck on it for a minute until it expires, additionally flooding the output log with errors once finishing, which is not ideal - so this is just a temporary fix until the bug is properly figured out. I've put more info about it in the issue.

DiasFranciscoA commented 3 months ago

@Indibulous there are some tests in the BasicVariableTestSuite that deal with builtin named struct variables:

image

can you please check if commenting these solved the issue? Basically commenting the:

other: value,
all: value,
noone: value,
global: value,
undefined: value,
...
true: value,
false: value,
pi: value,
NaN: value,
infinity: value,

I suspect it might be one of these.... probably good to track down which one 🤔