YoYoGames / GM-TestFramework

Repository for GameMaker's Test Framework
Other
18 stars 9 forks source link

Extend string_concat() and string_join() to test combinations of strings with variables #78

Closed gnysek closed 1 week ago

gnysek commented 2 weeks ago

Description

There was recently an issue, in which string_concat, and string_join, were failing under very specific condition - if penultimate argument was a variable name, and last argument was a literal string - https://github.com/YoYoGames/GameMaker-Bugs/issues/6480 .

Basic idea is to extend BasicStringTestSuite for those functions (and their _ext versions, to include such specific cases too.

Steps To The Task

gnysek commented 2 weeks ago

@YYDan there's issue with contributing:

  1. Back on your issue in our repository, set the branch in the right-hand side to be a new branch back on your own fork

Nothing is clickable for users outside of YYG in right side panel, that's how it looks on my side:

obraz

YYDan commented 2 weeks ago

Yeah, I am looking into a few issues for external contributors at the moment, but thanks for letting me know.