search

YoYoGames / GMEXT-IronSource

Repository for GameMaker's IronSource Extension
Other
1 stars 1 forks source link

No Load() function for Rewarded Video #1

Closed FuseGamesLLC closed 9 months ago

FuseGamesLLC commented 10 months ago

I am able to get a callback for ironsource_rewardedvideo_init(), but no callback for video ready or show. I noticed for interstitial there's a separate Load() function. Am I missing something or does there need to be a rewarded_video_load() as well? Thanks!

FuseGamesLLC commented 9 months ago

Hi, is there any update on a time line to upload a new version with the load() function included? Thanks!

jzavala-YYG commented 9 months ago

Previously we used automatic load for Rewarded Video ads, Currently we are using a manual load. now it's mandatory call ironsource_rewarded_video_load() to show Rewarded Video ads

FuseGamesLLC commented 9 months ago

Previously we used automatic load for Rewarded Video ads, Currently we are using a manual load. now it's mandatory call ironsource_rewarded_video_load() to show Rewarded Video ads

That's the issue I was raising, there is no ironsource_rewarded_video_load() to call, that function isn't part of the included bundle like how ironsource_interstitial_load() is.

jzavala-YYG commented 9 months ago

Previously we used automatic load for Rewarded Video ads, Currently we are using a manual load. now it's mandatory call ironsource_rewarded_video_load() to show Rewarded Video ads

That's the issue I was raising, there is no ironsource_rewarded_video_load() to call, that function isn't part of the included bundle like how ironsource_interstitial_load() is.

Check last commits now is _ironsource_rewarded_videoload() it's there. The extension worked correctly without it but now for consistence with other extensions and interstitial ad format we changed to manual mode for Rewarded Ad format

You can export the extension from this commit and should be presented da9124649f3dc23b97d9700f342442a9562c8abf

keep an eye in the callbacks type

FuseGamesLLC commented 9 months ago

Previously we used automatic load for Rewarded Video ads, Currently we are using a manual load. now it's mandatory call ironsource_rewarded_video_load() to show Rewarded Video ads

That's the issue I was raising, there is no ironsource_rewarded_video_load() to call, that function isn't part of the included bundle like how ironsource_interstitial_load() is.

Check last commits now is _ironsource_rewarded_videoload() it's there. The extension worked correctly without it but now for consistence with other extensions and interstitial ad format we changed to manual mode for Rewarded Ad format

You can export the extension from this commit and should be presented da91246

keep an eye in the callbacks type

Got it thank you so much for the quick reply!

I apologize but I'm a little lost in how to import the new version, I tried downloading the raw file and swapping copying the files into my project but it won't build, and I tried importing the project but can't seem to do that either. How do I update my older version with a version from github?

jzavala-YYG commented 9 months ago

First download or clone the repository locally, then open the GameMaker project and go to Tools -> Create Local Package, include the IronSource extension, press ok and save the package

Now open your GameMaker project, go to Tools -> Import Local Package and select the package created and select the extension

If you have any problem please let us know

Thanks

FuseGamesLLC commented 9 months ago

Ok that's what I did but unfortunately I was getting the following error. It looks like I have some conflicts with my existing extensions for AdMob?

Task :com.FuseGamesLLC.IdleSpaceForce:createDebugCompatibleScreenManifests

Task :com.FuseGamesLLC.IdleSpaceForce:extractDeepLinksDebug

Task :com.FuseGamesLLC.IdleSpaceForce:processDebugMainManifest FAILED package="com.FuseGamesLLC.IdleSpaceForce" found in source AndroidManifest.xml: C:\Users\steve\AppData\Roaming\GameMakerStudio2\Cache\GMS2CACHE\IdleSpaceT_3F182F82_E8C09FD\android\Default\com.FuseGamesLLC.IdleSpaceForce\src\main\AndroidManifest.xml. Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information. C:\Users\steve\AppData\Roaming\GameMakerStudio2\Cache\GMS2CACHE\IdleSpaceT_3F182F82_E8C09FD\android\Default\com.FuseGamesLLC.IdleSpaceForce\src\main\AndroidManifest.xml:10:1-63 Warning: Element uses-permission#android.permission.INTERNET at AndroidManifest.xml:10:1-63 duplicated with element declared at AndroidManifest.xml:8:1-63 C:\Users\steve\AppData\Roaming\GameMakerStudio2\Cache\GMS2CACHE\IdleSpaceT_3F182F82_E8C09FD\android\Default\com.FuseGamesLLC.IdleSpaceForce\src\main\AndroidManifest.xml:11:1-75 Warning: Element uses-permission#android.permission.ACCESS_NETWORK_STATE at AndroidManifest.xml:11:1-75 duplicated with element declared at AndroidManifest.xml:7:1-75 C:\Users\steve\AppData\Roaming\GameMakerStudio2\Cache\GMS2CACHE\IdleSpaceT_3F182F82_E8C09FD\android\Default\com.FuseGamesLLC.IdleSpaceForce\src\main\AndroidManifest.xml:108:9-106 Error:

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

Element meta-data#com.google.android.gms.ads.APPLICATION_ID at AndroidManifest.xml:108:9-106 duplicated with element declared at AndroidManifest.xml:87:1-136

C:\Users\steve\AppData\Roaming\GameMakerStudio2\Cache\GMS2CACHE\IdleSpaceT_3F182F82_E8C09FD\android\Default\com.FuseGamesLLC.IdleSpaceForce\src\main\AndroidManifest.xml Error: Validation failed, exiting

Task :com.FuseGamesLLC.IdleSpaceForce:mergeDebugResources

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.

2: Task failed with an exception.

11 actionable tasks: 11 executed

BUILD FAILED in 5s

jzavala-YYG commented 9 months ago

You shouldn't use both extensions at same time, for that are the mediations

Delete one of the extensions and check which mediations you will use

FuseGamesLLC commented 9 months ago

You shouldn't use both extensions at same time, for that are the mediations

Delete one of the extensions and check which mediations you will use

Thank you for all of your help! For what it's worth while updating I forgot to add my AppID to the Mediation Extension.

I think something might still be wonky with the new code though since I wasn't able to receive any Async Init events, but I was able to load interstitials with the old code base that's on marketplace so that's what I'll do for now. Thanks again for the quick replies, it really helps!