YoYoGames / GameMaker-Bugs

Public tracking for GameMaker bugs
21 stars 8 forks source link

UI/UX: Request to allow Enter rather than F2 for renaming assets #2813

Open jschoeny opened 10 months ago

jschoeny commented 10 months ago

Description

Most modern programs let you rename something by simply selecting it and pressing the Enter key. GameMaker seems to simulate a click instead when pressing Enter.

For example, in the Asset Browser, pressing Enter with an asset selected opens the asset. Under the Layers window for a room, selecting a layer and pressing Enter does nothing.

However, if I right click on any renamable item and click Rename, the Enter key will now trigger a rename for that item. If the item is deselected, the default Enter key action is restored.

I propose that the Space key should be used for simulating a click (like most other modern programs), and Enter should be used for renaming.

(Also, more generally, navigation of IDE menu items using the keyboard is very inconsistent and unintuitive.)

Steps To Reproduce

Select an asset in the Asset Browser. Press 'Enter'. Asset should open in the workspace. Right click on the Asset in the Asset Browser. Select Rename. Press 'Enter' to finish renaming. Press 'Enter' again. A Rename should be triggered again instead of opening the asset. A Rename will trigger until another Asset is selected.

b34544fd-4211-46f5-bf78-35b552e943c0

stuckie commented 10 months ago

We should look to see if this could be a redefinable key entry.

gnysek commented 9 months ago

In fact I don't know any IDE which would rename files with Enter. Most of them is opening files/editors with that shortcut... and renames by using F2, or Ctrl+R (but it rather means Refactor not Rename in many IDEs, as it also refactors code if class name is same as file).

Also:

the Enter key will now trigger a rename for that item

It would finish renaming, but not trigger anything. Same if you press enter in some input fields in many many applications, it would apply new values or submit forms, and GM isn't alone in such behaviour - generally if some field is not intended for multiline text, Enter means "update/finish". This sounds like very far-fetched argument.

However, I like the idea of adding option, that it could be done by redefinable key setting in options - this way if someone seems that this would be more intuitive - could change default behaviour.

jschoeny commented 6 months ago

In fact I don't know any IDE which would rename files with Enter. Most of them is opening files/editors with that shortcut... and renames by using F2, or Ctrl+R (but it rather means Refactor not Rename in many IDEs, as it also refactors code if class name is same as file).

Apologies, it turns out the Return/Enter key is actually just the standard renaming shortcut for macOS, not Windows.

In general, from what I've found, it appears that GameMaker tends towards a more Windows-centric UX-language. Not uncommon for Mac apps developed by people who don't daily drive a Mac.

gnysek commented 6 months ago

If that's common on macOS, then indeed it could be like that by default on that platform - should be not an issue to have different list of default hotkeys between platforms, from what I've seen it's very common for many apps (like Cmd+, for preferences, while on Windows there's usually no shortcut for that at all), I'm seeing it also when using linux, that same app sometimes have different key combination compared to Windows.

With addition of "macOS" info, it explains a lot, I hope that YYG would consider it then :)