YoYoGames / GameMaker-Bugs

Public tracking for GameMaker bugs
21 stars 8 forks source link

Manual Content: Various dev/debug async dialog pages state it shouldn't be used in released games, but this should clarify "on desktop OSes" #6419

Closed jackerley closed 1 month ago

jackerley commented 10 months ago

Various dev/debug async dialog pages state that function shouldn't be used in released games, but this message should clarify we only mean this for desktop and HTML5 games, as it's fine on consoles & mobiles to bring the system UI up to get their own OS dialogs - it's only on desktops that it brings up our runner dialogs.

YYBartT commented 8 months ago

There are currently notes on the manual pages of the related functions get_login_async, get_integer_async, show_message_async and show_question_async with the same message. Still to verify if these functions behave the same as get_string_async.

YYBartT commented 6 months ago

Made a QA request to confirm that the functions mentioned above all do show a suitable OS-supplied dialog rather than GameMaker's own dialogs, using this project: test_async_functions.zip

cameron-home commented 1 month ago

This is how these look on various non-desktop platforms: Android: Android Screenshots-20240723T140853Z-001.zip

iOS: iOS Screenshots-20240723T140855Z-001.zip

PS4, PS5 and Switch all use their in built UI. I could not build attached project to Xbox, so unsure as to if it does. Xbox compiler error: 6419XboxCompileErrors.txt

Testing was done using IDE v2024.800.0.595 Runtime v2024.800.0.617

jackerley commented 1 month ago

@cameron-home Xbox error should be fixed in 2024.800.0.619 btw

cameron-home commented 1 month ago

@jackerley Ah, thanks! I'll take a look on Xbox when that's ready then, and will update here accordingly with results

cameron-home commented 1 month ago

Having updated to the correct runtime, I can see that Xbox also uses the built in UI @YYBartT

YYBartT commented 1 month ago

Thanks for testing, @cameron-home!

The manual has now been updated. All async dialog function pages now have a note added. Also added a warning note to the get_login_async() page requesting that passwords should be encrypted. All changes are currently in the develop.bart branch and will go in the next manual release.

cameron-home commented 3 weeks ago

@YYBartT What do the notes look like? Just taking a look at the pages now. I've verified the password encryption warning at least.

YYBartT commented 3 weeks ago

@cameron-home The actual note added to all the async function pages looks like this:

image

cameron-home commented 3 weeks ago

The notes are all verified present and correct in latest manual build so marking as Verified.