search

YoYoGames / GameMaker-Bugs

Public tracking for GameMaker bugs
23 stars 8 forks source link

Go To: Now shows functions and constants, however these are not links to those code locations #7378

Open gm-bug-reporter[bot] opened 1 month ago

gm-bug-reporter[bot] commented 1 month ago

Description

In Preferences, I set Go To to only search in Assets. However, this still displays functions and constants, yet clicking on them does not open the function/constant. Clicking on assets works as intended.

Steps To Reproduce

  1. Make a new project
  2. Make a new script
  3. Add a macro to it
  4. In Preferences > Go To, set it so it only searches in Assets
  5. Ctrl + T and type in the macro name. It will show the Constant (even though the Constant isn't an asset)
  6. Click on the result. It doesn't do anything.

Which version of GameMaker are you reporting this issue for?

IDE v2024.800.0.613 Runtime v2024.800.0.636

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

114f044e-17d6-47fa-8fbb-82abe9ece11c

zreedy commented 1 month ago

Incidentally fixed while working on https://github.com/YoYoGames/GameMaker-Bugs/issues/6478 The issue was that the relative path collapse was not case-insensitive and that could result in some in-memory assets not being found despite having a link.

alicemoretti commented 2 weeks ago

On IDE v2024.1100.0.626 Runtime v2024.1100.0.652, I'm not able to search for Macros using GoTo even with all of the search preferences enabled.

Is that the expected result of the fix?

yerumaku commented 2 weeks ago

On IDE v2024.1100.0.626 Runtime v2024.1100.0.652, I'm not able to search for Macros using GoTo even with all of the search preferences enabled.

On IDE v2024.1100.0.626 macOS F1/Go To Declaration (rigth click) the functionality works.

YYDan commented 2 weeks ago

You're talking about something different, so yes that would work.

You're talking about this: image

(I would also suggest you do not use our pre-release internal versions, as your comment here has just caused confusion and therefore us to have to do additional work to confirm your comment and also explain why we reopened an issue.)

YYDan commented 2 weeks ago

Alice is definitely correct.

Go To finds no matches for macros: image

And there are no Preferences for enabling/controlling this either: image

Whereas functions (which do have their own Preference) still work: image