In-Game: Filters and Effects are not correctly applied to cropped surfaces which are bigger than the application_surface

TrianglyRU commented 3 weeks ago

Description

See Title and Steps To Reproduce

Steps To Reproduce

have an active application_surface
have a camera wider the application_surface
have a surface assigned to the camera the same resolution as the camera
crop the surface's sides and shift it to display the camera correctly on the screen
apply any filter or effect

Which version of GameMaker are you reporting this issue for?

IDE v2024.8.0.169 Runtime v2024.8.0.216

Which operating system(s) are you seeing the problem on?

Windows 10.0.19045.0

Which platform(s) are you seeing the problem on?

Windows

Attached Files

Безымянный

YYDan commented 3 weeks ago

Presumably a knock-on from the fix in https://github.com/YoYoGames/GameMaker-Bugs/issues/7252

TrianglyRU commented 3 weeks ago

Here's RenderDoc draw call in case that would help, EID 170. Also, the background is rendered twice for some reason, I think there are some internal surface shenanigans going on background_capture.zip

TrianglyRU commented 3 weeks ago

From my observation, what it does is:

it draws the background on a surface
then it copies the surface onto a separate buffer and applies a filter
it then draw that very buffer ontop of the said surface without cleaning the surface itself

The problems here goes way, way deeper than it looks

YoYoGames / GameMaker-Bugs