search

YoYoGames / GameMaker-Bugs

Public tracking for GameMaker bugs
26 stars 8 forks source link

If more than two duplicate resources are polluted by git within .yyp, issues in code that uses the object_index #8406

Open OnlookerRian opened 1 week ago

OnlookerRian commented 1 week ago

Description

This issue sometimes occurs during collaboration through git.

A simple way to check if this issue is occurring is to look for warnings during the yyc build.

This problem was identified when code handling object assets produced different IDs for the same asset, and this was the cause.

Note. The test project has five identical assets duplicated as an extreme example for easy verification.

Solution When opening the project, duplicate resources should be removed except for one. and should inform about the removed duplicated.

Steps To Reproduce

  1. run project
  2. see same name, diffrent object_index

Which version of GameMaker are you reporting this issue for?

IDE v2024.8.1.171 Runtime v2024.8.1.218

Which operating system(s) are you seeing the problem on?

Windows 10.0.19045.0

4356f8b4-b74b-4552-a160-4a78cffb7f13

stuckie commented 1 week ago

The attached project definitely has errors, but it's not showing what you're meaning here as the object you've duplicated in the yyp does not actually have it's .yy file, so the project cannot be opened.

OnlookerRian commented 6 days ago

duplicate_asset_bug.zip

I have uploaded it again because it's strange that the related .yy file is missing even though I attached it correctly.

The previous upload was done automatically through the "Report a GameMaker Bug". If the file wasn't included, I think it might be related to that.

stuckie commented 3 days ago

That project is still broken. If you extract that yourself you can see that objects/obj_target/obj_target.yy is missing so the project will not load.

OnlookerRian commented 2 days ago

That project is still broken. If you extract that yourself you can see that objects/obj_target/obj_target.yy is missing so the project will not load.

That's strange... There are issues when using both local packages and export.

I will directly compress the project and upload it.

duplicate_asset_bug.zip

stuckie commented 2 days ago

Perfect, that works now ( well, works as in showcases the original bug! ) I suspect the export functionality probably attempted to fix the brokenness and messed it up further.

jonathan-markland commented 1 day ago

https://github.com/YoYoGames/CoreResources/pull/368