Sequence Editor: GM crash when creating a delay audio effect track

gm-bug-reporter[bot] commented 1 week ago

Description

The version of yyal used in the IDE uses a 'default' allocator - which happens not to zero memory. There are a fair few areas in the library which assume that memory is zeroed (as it has been in the runner's allocator for a very long time).

In this particular case, write frames for the delay effect are uninitialised, and this leads to out-of-bounds memory accesses when writing to the delay line.

Steps To Reproduce

Open the attached project: gmb-8408-x.zip
Open the sequence seq_1.
Drag the sound snd_1 into the track panel to add an audio track.
Add a delay effect track to the audio track.
The IDE may crash at this point.

Which version of GameMaker are you reporting this issue for?

IDE v2024.1100.0.674 Runtime v2024.1100.0.700

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

10f5e03e-b832-4acc-b7ca-20cfea5b1fd1

toby-yoyo commented 1 week ago

Made sure that yyal's default allocator zeroes any memory it allocates.

Emc1923 commented 4 days ago

Verified in IDE v2024.1100.0.687 Runtime v2024.1100.0.708

YoYoGames / GameMaker-Bugs