search

Yoast / PHPUnit-Polyfills

Set of polyfills for changed PHPUnit functionality to allow for creating PHPUnit cross-version compatible tests
BSD 3-Clause "New" or "Revised" License
173 stars 13 forks source link

GH Actions: run tests against PHPUnit PHAR files as well #160

Closed jrfnl closed 7 months ago

jrfnl commented 7 months ago

PHPUnit 8.5.38 and 9.6.19 contain a change in the PHAR build process, which means that classes external to PHPUnit are now prefixed differently, which breaks one polyfill.

As things were, such issues would previously not be caught by CI.

This commit adds a new job to the test workflow, which will run the tests against a range of PHP-PHPUnit combinations using the PHPUnit Phar to ensure any such issues will be automatically caught in the future.

The new test workflow will (very) selectively also upload code coverage to safeguard that the PHAR-file specific lines in the code base remain covered by tests as well.

jrfnl commented 7 months ago

See #161 for context about the specific change which was problematic in these latest PHPUnit releases.

coveralls commented 7 months ago

Coverage Status

coverage: 96.264% (+0.4%) from 95.833% when pulling 73959970d0437bfaf6e81df4992296b714ae9e82 on feature/ghactions-add-phar-testing-job into 51c24157af1a328e861735d50a9c0ae654957050 on 1.x.